Issue metadata
Sign in to add a comment
|
limit=200 link no longer works |
||||||||||||||||||||||
Issue descriptionIf I click "200" at the bottom of https://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia , it redirects tohttps://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia/?limit=200 (note the wrong '/' in front of the '?') and I don't get 200 builds but just the default number. This is a recent (last 3 days?) regression.
,
Jul 18 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f commit 746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f Author: hinoka <hinoka@google.com> Date: Wed Jul 19 00:17:57 2017 Milo: Fix ?limit= param This is actually a query (form) parameter, not a router parameter. BUG= 745757 Review-Url: https://codereview.chromium.org/2976393002 [modify] https://crrev.com/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f/milo/buildsource/builder.go [modify] https://crrev.com/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f/milo/frontend/middleware.go [modify] https://crrev.com/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f/milo/frontend/view_builder.go
,
Jul 20 2017
Does the fix have to be deployed still?
,
Jul 20 2017
It should be rolled and fixed now. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpranke@chromium.org
, Jul 18 2017Components: -Infra Infra>Platform>Milo
Labels: -Restrict-View-Google