New issue
Advanced search Search tips

Issue 745729 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

OpenSplitModeExtensionOptionsPageIncognito is flaky on Windows 7

Project Member Reported by peter@chromium.org, Jul 18 2017

Issue description

Looks like there's race somewhere when recreating the Incognito browser window.

4248:4028:0718/060258.467:FATAL:dependency_manager.cc(108)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again.
Backtrace:
	base::debug::StackTrace::StackTrace [0x100AF1F7+55]
	base::debug::StackTrace::StackTrace [0x100AEE91+17]
	logging::LogMessage::~LogMessage [0x1010384E+94]
	DependencyManager::AssertContextWasntDestroyed [0x1C515EB1+241]
	KeyedServiceBaseFactory::AssertContextWasntDestroyed [0x1C518D96+22]
	BrowserContextKeyedServiceFactory::GetContextToUse [0x1CE39703+19]
	KeyedServiceFactory::GetServiceForContext [0x1C51FD74+180]
	BrowserContextKeyedServiceFactory::GetServiceForBrowserContext [0x1CE39748+24]
	InProcessPrefServiceFactoryFactory::GetInstanceForContext [0x0689ABE6+22]
	OffTheRecordProfileImpl::RegisterInProcessServices [0x0516B0CF+31]
	content::BrowserContext::Initialize [0x11BB5647+983]
	OffTheRecordProfileImpl::OffTheRecordProfileImpl [0x05169F12+162]
	Profile::CreateOffTheRecordProfile [0x0516A578+56]
	ProfileImpl::GetOffTheRecordProfile [0x05121B36+38]
	InProcessBrowserTest::CreateIncognitoBrowser [0x027F8F11+81]
	extensions::ExtensionTabUtilBrowserTest_OpenSplitModeExtensionOptionsPageIncognito_Test::RunTestOnMainThread [0x011E240E+3614]

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)

This flaked four times already today:
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61658
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61654
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61653
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61652

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2120bba6e30982e60c4cd8c8dc5a3d59b9e1a9a

commit d2120bba6e30982e60c4cd8c8dc5a3d59b9e1a9a
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Jul 18 15:06:19 2017

Disable one of the ExtensionTabUtilBrowserTests on Windows

OpenSplitModeExtensionOptionsPageIncognito flaked six times today, in
builds 61651-61654, 61658 and 61659, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61659

TBR=catmullings@chromium.org
BUG=745729

Change-Id: I15a827faea250f5bbda74c791b2141f00df3d594
Reviewed-on: https://chromium-review.googlesource.com/575051
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487473}
[modify] https://crrev.com/d2120bba6e30982e60c4cd8c8dc5a3d59b9e1a9a/chrome/browser/extensions/extension_tab_util_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829c824b54747b770a8605ab5566a75cb029b3d3

commit 829c824b54747b770a8605ab5566a75cb029b3d3
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jul 20 02:27:39 2017

[Profiles] Mark profile contexts as live in Profile construction

The KeyedServiceDependencyManager marks contexts as live in order to
detect when a context is used after shutdown is initiated. Ensure that
Profile contexts are marked as live by calling
BrowserContextDependencyManager::GetInstance()->MarkBrowserContextLive(this);
from the Profile constructor.

Bug: 745729

Change-Id: Icaa7950d77c1e33cbc098da8282ba3ff7f6977f3
Reviewed-on: https://chromium-review.googlesource.com/576339
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488101}
[modify] https://crrev.com/829c824b54747b770a8605ab5566a75cb029b3d3/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/829c824b54747b770a8605ab5566a75cb029b3d3/chrome/test/base/testing_profile.cc

Cc: -catmulli...@chromium.org

Sign in to add a comment