Histograms for Touch Action Metrics |
||||
Issue description
Touch Action metrics will be measured in two categories:
1. How often do we hit each touch action? (None, PanLeft, PanRight,
etc)
2. What is the comparison between white-listed touch action vs gesture
event look like?
a. How often do we hit the case where the users’ gesture event is
the same as white-listed touch action.
b. How often do we hit the case where users’ gesture is not the same
as white-listed, but is allowed by blink’s effective touch
action.
c. How often does the gesture event doesn’t match blink’s effective
touch action.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d490d3f717e82688efeabdf117dc9cfa91221bcd commit d490d3f717e82688efeabdf117dc9cfa91221bcd Author: Hayley Ferr <hayleyferr@chromium.org> Date: Wed Jul 19 20:27:17 2017 Added a histogram for effective touch action metrics. Added an UMA_HISTOGRAM_ENUMERATION to report how often we hit each touch action. Bug: 745718 Change-Id: I21d48c48a30f5b7699b078212ae105d34506c156 Reviewed-on: https://chromium-review.googlesource.com/571270 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487957} [modify] https://crrev.com/d490d3f717e82688efeabdf117dc9cfa91221bcd/content/browser/renderer_host/input/legacy_input_router_impl.cc [modify] https://crrev.com/d490d3f717e82688efeabdf117dc9cfa91221bcd/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d490d3f717e82688efeabdf117dc9cfa91221bcd/tools/metrics/histograms/histograms.xml
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49a2a2e2f2529d981b81624f1b124db0995df728 commit 49a2a2e2f2529d981b81624f1b124db0995df728 Author: Hayley Ferr <hayleyferr@chromium.org> Date: Thu Jul 20 17:47:00 2017 Histogram for gesture events being dropped based on allowed touch action. Added an UMA_HISTOGRAM_BOOLEAN to report how often a gesture event is or is not dropped based on the current touch action state not matching the gesture event. Bug: 745718 Change-Id: Ib1c9f91cfcaa846f3e8bba9a7b1c87f698b2a962 Reviewed-on: https://chromium-review.googlesource.com/575071 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#488296} [modify] https://crrev.com/49a2a2e2f2529d981b81624f1b124db0995df728/content/browser/renderer_host/input/touch_action_filter.cc [modify] https://crrev.com/49a2a2e2f2529d981b81624f1b124db0995df728/tools/metrics/histograms/enums.xml [modify] https://crrev.com/49a2a2e2f2529d981b81624f1b124db0995df728/tools/metrics/histograms/histograms.xml
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0ae2e3fdad3940257db1953e231327f837cf859 commit b0ae2e3fdad3940257db1953e231327f837cf859 Author: Hayley Ferr <hayleyferr@chromium.org> Date: Thu Jul 20 19:44:38 2017 Histogram for equivalent effective and whitelisted touch actions Report how often the effective touch action computed by blink is or is not equivalent to the whitelisted touch action computed by the compositor. Bug: 745718 Change-Id: Ieb080bbd6791d8bfaafafd134c2406537000287a Reviewed-on: https://chromium-review.googlesource.com/575585 Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488360} [modify] https://crrev.com/b0ae2e3fdad3940257db1953e231327f837cf859/content/browser/renderer_host/input/legacy_input_router_impl.cc [modify] https://crrev.com/b0ae2e3fdad3940257db1953e231327f837cf859/content/browser/renderer_host/input/touch_action_filter.cc [modify] https://crrev.com/b0ae2e3fdad3940257db1953e231327f837cf859/content/browser/renderer_host/input/touch_action_filter.h [modify] https://crrev.com/b0ae2e3fdad3940257db1953e231327f837cf859/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b0ae2e3fdad3940257db1953e231327f837cf859/tools/metrics/histograms/histograms.xml
,
Aug 24 2017
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edfc54c66d22c01487c6f70077caed6a3f865c8d commit edfc54c66d22c01487c6f70077caed6a3f865c8d Author: Xida Chen <xidachen@chromium.org> Date: Fri Feb 09 16:32:36 2018 Report touch action at the end of a touch sequence In the InputRouterImpl::OnTouchEventAck, we reset touch action when it is at the end of a touch-action sequence. We should instead do ReportAndResetTouchAction. Bug: 745718 Change-Id: Ibd28c866ee06b3472871c08b4b851860176e9550 Reviewed-on: https://chromium-review.googlesource.com/908708 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#535732} [modify] https://crrev.com/edfc54c66d22c01487c6f70077caed6a3f865c8d/content/browser/renderer_host/input/input_router_impl.cc
,
Nov 13
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36070799a44c7e0210002336a5c3ad6b44ce6b54 commit 36070799a44c7e0210002336a5c3ad6b44ce6b54 Author: Xida Chen <xidachen@chromium.org> Date: Tue Nov 20 14:25:51 2018 Add histogram for gesture event filtering results When the kCompositorTouchAction flag is on, we use the white listed touch action to process a gesture event. This CL adds histogram to measure how often a GSB and GSU is allowed / filtered / deferred by the main thread / compositor thread touch action. Bug: 745718 Change-Id: I2a8b16904ad9fa3f75249d4a1bb10aa0849094ce Reviewed-on: https://chromium-review.googlesource.com/c/1340588 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609690} [modify] https://crrev.com/36070799a44c7e0210002336a5c3ad6b44ce6b54/content/browser/renderer_host/input/touch_action_filter.cc [modify] https://crrev.com/36070799a44c7e0210002336a5c3ad6b44ce6b54/tools/metrics/histograms/enums.xml [modify] https://crrev.com/36070799a44c7e0210002336a5c3ad6b44ce6b54/tools/metrics/histograms/histograms.xml
,
Nov 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xidac...@chromium.org
, Jul 18 2017