New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 745661 link

Starred by 2 users
Status: Assigned
Owner:
thestig@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
rbpotter@chromium.org
█ ranjitkan@chromium.org
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scroll bar is seen on ‘Select a destination’ overlay of print preview.

Reported by aiman.an...@etouch.net, Jul 18 2017 
Chrome Version: 61.0.3160.0 (Official Build) 226c080a029bd3ff8a6a577503cefe316c84325b-refs/heads/master@{#487322}(64-bit)

OS: Mac(10.1.6, 10.12.3).

Steps to reproduce:
1). Launch Chrome, go to NTP, give print command and click on Change button for Destination.
2). On ‘Select a destination’ overlay, enter some data in text box and observe.

Actual Result: Unwanted scroll bar is seen even when there is no destination in the list.
Expected Result: Scroll bar should not be seen.

This is Regression issue broken in M-59 and will soon update bisect info.

Manual Bisect Info:
Good Build: 59.0.3043.0
Bad Build: 59.0.3044.0

Note: Issue is not seen on Linux and Win OS.
Actual Result.mov
1.7 MB Download
Expected Result.mov
2.3 MB Download

Comment 1 by rbasuvula@chromium.org, Jul 18 2017

Labels: hasbisect-per-revision
Owner: e...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3043.0(Revision:457297).
Bad build:59.0.3044.0(Revision:457648).

You are probably looking for a change made after 457608 (known good), but no later than 457609 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/db917052bfb936546b2602cdb657c310778c6451..9b998d1b33fa699e3580e35bc817580706931d13

From the CL above, assigning the issue to the concern owner

@eae: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2679193006
Note : Mac specific issue and Able to reproduce in latest Canary #61.0.3160.0

Comment 2 by e...@chromium.org, Aug 3 2017

Owner: ----
Status: Untriaged (was: Assigned)
UI makes assumption about text metrics that are incorrect. Requires a change in the PrintPReview UI code.

Comment 3 by thestig@chromium.org, Aug 8 2017

Owner: thestig@chromium.org
I'll put it in my queue.

Comment 4 by thestig@chromium.org, Aug 9 2017

Cc: shrike@chromium.org
Labels: -Pri-1 Pri-2
shrike: I can't reproduce this, can you?

Minor issue, so let's demote from P1.

Comment 5 by shrike@chromium.org, Aug 10 2017 

I cannot reproduce it either.

Comment 6 by thestig@chromium.org, Aug 23 2017

Cc: rbpotter@chromium.org
Labels: -M-61
I can on a 10.9 test Mac. Maybe the key to the repro is to not be signed in to Chrome, or to just have no printers installed?

The destination selection dialog is a bit shorter than on my other Mac due to the lack of printers. The <div> that holds the lists has a height of 146px, whereas the two lists inside each has a height of 74px, for a total of 148px. Maybe something in Blink layout changed, and now this just overflows.

Comment 7 by thestig@chromium.org, Aug 23 2017

Status: Assigned (was: Untriaged)
Probably need to adjust some of the height calculations in chrome/browser/resources/print_preview/search/destination_search.js and/or chrome/browser/resources/print_preview/search/destination_list.js.

Comment 8 by thestig@chromium.org, Aug 23 2017 

On Linux, the container is 142px, and the two lists are 71px each.
►

Sign in to add a comment