VH Units works incorrectly
Reported by
hololelo...@gmail.com,
Jul 18 2017
|
||||||
Issue descriptionSteps to reproduce the problem: 1. Open link http://lelouch.ru/bugs/vh/ 2. You should see some pink area with text explains issue What is the expected behavior? What went wrong? In Google Chroke desktop it works correctly, but not in Chrome Mobile. The pink area should be 50% height of browser viewport without adres bar (50vh) like position fixed and height: 50%, but it's not! The fact that the pink area is 50% height of browser viewport WITH ADRES BAR, But it should not be. Otherwise it doesn't make sense. Please check this links and please do something with it. It's really necessary, and It's very painful that it's broken on Chrome Mobile. Thank you. http://lelouch.ru/bugs/vh/ http://lelouch.ru/bugs/vh/should_not_should.png Did this work before? No Chrome version: 59.0.3071.125 Channel: stable OS Version: 7.0 Flash Version:
,
Jul 27 2017
Over to the android team for further triage. Not sure what the desired behavior is here, if it is to always have vh resolve against the height of the viewport *without* the address bar then that height needs to be sent to blink to do the resolution.
,
Jul 28 2017
VH should always be without the address bar on mobile IMO. I've spent waaay too much time getting my sites to not jump around on mobile Chrome as the address bar hides and shows. Mobile Safari gets this right in my view: ------- This is completely intentional. It took quite a bit of work on our part to achieve this effect. :) The base problem is this: the visible area changes dynamically as you scroll. If we update the CSS viewport height accordingly, we need to update the layout during the scroll. Not only that looks like shit, but doing that at 60 FPS is practically impossible in most pages (60 FPS is the baseline framerate on iOS). It is hard to show you the “looks like shit” part, but imagine as you scroll, the contents moves and what you want on screen is continuously shifting. Dynamically updating the height was not working, we had a few choices: drop viewport units on iOS, match the document size like before iOS 8, use the small view size, use the large view size. From the data we had, using the larger view size was the best compromise. Most website using viewport units were looking great most of the time. from: https://bugs.webkit.org/show_bug.cgi?id=141832
,
Nov 13 2017
Able to reproduce the issue on Android. Steps Followed: 1. Open link http://lelouch.ru/bugs/vh/ 2. You should see some pink area with text explains issue Chrome versions tested: Chrome Stable# 62.0.3202.84 Chrome Canary# 64.0.3267.0 OS Android 8.1.0 Android Devices Pixel XL / OPM1.171019.005 This seems to be a Non-Regression issue as same behavior is seen since M55. Untriaged for further input's on this issue. Please navigate to below link for log's and video-- go/chrome-androidlogs/745528 Note: This issue is not observed in Desktop. This issue is not reproducible on Firefox Android. Attached a screenshot accordingly. Thank You.
,
Feb 7 2018
+bokan for fullscreen-y things (maybe add back someone from Blink that might know more about this) And adding back Blink>Layout, as I have no idea what vh is nor what properties it is set from. We generate the ResizeParams here: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=GetResizeParams&sq=package:chromium&l=727 I have no idea what of those Blink is using to calculate the various heights, but if there can be guidance there then we can figure out if we are passing the incorrect value.
,
Feb 7 2018
,
Feb 7 2018
This was an intentional change in M60 and matches mobile Safari. There details and rationale are documented in https://developers.google.com/web/updates/2016/12/url-bar-resizing |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by caseq@chromium.org
, Jul 19 2017