New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745468 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

:hover is lost while selecting an autofill suggestion

Project Member Reported by phistuck@gmail.com, Jul 18 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Go to data:text/html,<!doctype html><form><input name="email"><br/><input type="submit"></form><style>form:hover { background:blue }</style>
 (For making sure you have autofill suggestions for this field, follow these steps)
 1a. Focus on the text field.
 1b. Enter some text.
 1c. Press Enter.
2. Focus on the text field.
3. Press the down arrow of the keyboard, or double click.
4. Hover over the autofill suggestions with the mouse.

What is the expected behavior?
The form has a blue background.

What went wrong?
While it is interoperable, the form does not have a blue background.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

In contrast, right click on the blue background and hover over the context menu - the background will remain blue.
 
Labels: -Arch-x86_64 Hotlist-Interop
Status: Untriaged (was: Unconfirmed)
Huh, it is not fully interoperable.
Safari keeps applying :hover.
Components: UI>Browser>Autofill
Labels: OS-Mac
Cc: mikelawther@chromium.org
Components: -Blink>CSS Blink>Input
Status: Unconfirmed (was: Untriaged)
I tested the example in Firefox 55 and Edge on Windows 10, and the behaviour is the same as Chrome (ie hover is lost when the mouse enters the autofill field).

Safari's behaviour seems to be the odd one out here.

Is there an example of a site or a usecase that is broken on Chrome, Firefox and Edge as a result of this?
Cc: ma...@chromium.org
The render view filters the mouse exit generated by the system when a WebPagePopup (like a html select) is passed but it seems not for autofill.

See:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_event_handler.cc?type=cs&l=579

mathp@
Is this Autofill client a separate window? If so is it possible to filter for it as well?
Labels: Needs-Milestone

Comment 6 by bokan@chromium.org, Jul 27 2017

Cc: bokan@chromium.org
ping mathp@, please see question in #4

Comment 7 by ma...@chromium.org, Jul 27 2017

The autofill popup is platform dependent... for example on Mac it's another NSWindow that's created. I'm not sure how difficult it would be to filter out the mouse exit events.
mathp@  is there an API like IsShowingAutofillOnPage that could be implemented and we could easily filter them out. See the code in comment #4 which uses a similar call to check for a context menu.
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac 10.12.6 with chrome #59.0.3071.115 and Canary #62.0.3179.0

Steps followed :

1. Entered the code from comment #0 in the omnibox.
2. Enter some text in the input field.
3. press enter button
4. Focus on the text input field.
5. It will display the previous entered text.

Observations:
1. If we use down arrow to select the text, we can see the blue back ground.
2. If we use mouse to select the text, we can't see blue back ground.

Observed the same behavior in firefox browser too...Attaching the screen-cast for reference.

phistuck@ Could you please look into it and confirm this is the issue you are experiencing ?

745468-FF.mp4
409 KB View Download
745468-Chrome.mp4
754 KB View Download
#9 - yes, this is the issue. Safari behaves in a nicer way, as mentioned in comment 1.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by ajha@chromium.org, Aug 10 2017

Labels: M-62 OS-Linux
Status: Untriaged (was: Unconfirmed)
Since the issue is reproduced in C#9 and as confirmed in C#10. Changing the status to 'Untriaged' and for further investigation of this. Issue is seen on Linux Ubuntu 14.04 using chrome version: 62.0.3181.0 as well.


Thank you!
Cc: dtapu...@chromium.org
Owner: ma...@chromium.org
Status: Assigned (was: Untriaged)
mathp@ can you please provide the content layer some API that the autofill popup is displayed. If we get this info we can filter the mouseleave events.

Comment 14 by ma...@chromium.org, Aug 28 2017

Cc: rogerm@chromium.org vabr@chromium.org
Hi dtapuska, happy to work with you to fix this. If I understand correctly, you'd like to register for an observer in the content layer, that would fire when the popup is shown/hidden?

Note that it's currently possible to get a ContentAutofillDriver for a given RenderFrameHost [1], but that we don't have observer events around the popup. Would that be a good place to put it?

Let me know what you have, and need. Thanks!

[1] https://cs.chromium.org/chromium/src/components/autofill/content/browser/content_autofill_driver_factory.h?rcl=d353b64c1d0bac38e3b5f658a3aa335c125583c9&l=54
mathp@ Ya that is totally doable if something is on RFH.. See https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?type=cs&l=4742 an example for which we could add an API to the RWHDelegate and implement it on WebContentsImpl.

Please go ahead and make an API on the ContentAutofillDriver as to whether the popup window is visible or not; and then I can take over from there.

Cc: se...@chromium.org
Status: Untriaged (was: Assigned)
Status: Assigned (was: Untriaged)
mathp@: please help us find someone who knows autofill enough to do #c15.

Comment 19 by ma...@chromium.org, May 10 2018

Owner: se...@chromium.org

Comment 20 by se...@chromium.org, May 11 2018

Just to be sure, is what you are looking for something like a IsPopupShowing() method in the content_autofill_driver?

Comment 21 by se...@chromium.org, May 11 2018

I made this real quick I still need to test it but let me know if this is what you are looking for: crrev.com/c/1055047
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment