New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745353 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 736322



Sign in to add a comment

Update dev-python/pyinotify and/or remove it from the build

Project Member Reported by djkurtz@chromium.org, Jul 18 2017

Issue description

The current dev-python/pyinotify ebuild is quite old and blocks updating python-3 from 3.3 to 3.6 (upstream tip) as required to update to OpenSSL 1.1:

 * Error: The above package list contains packages which cannot be
 * installed at the same time on the same system.

  (dev-lang/python-3.3.5-r1:3.3/3.3::portage-stable, installed) pulled in by
    =dev-lang/python-3.3* required by (dev-python/pyinotify-0.9.3:0/0::portage-stable, installed)

At present dev-python/pyinotify is only installed in the cros_sdk as a dependency in virtual/target-chromium-os-sdk.

This dependency was added by chromiumos-overlay commit:

772ac4d0ffbaddbed964dccf5b4b1f3fac22f064
Author: Jon Salz <jsalz@chromium.org>  2012-06-04 14:13:03
Add ws4py and pyinotify to hard-host-depends.

Based on the commit, I guess this package is/was used by the factory UI. 

Is it still used?

I have not been able to discover where pyinotify how it is actually used.
If so, we can try updating the ebuild to the latest from gentoo.

If it is no longer used, we can just remove it from target-chromium-os-sdk.
 

Comment 1 by hungte@chromium.org, Jul 18 2017

Owner: djkurtz@chromium.org
I'm not see pyinotify used in current factory.
You may try remove it.
It is straight-forward to update this package, so let's just do that first:

CL for update: https://chromium-review.googlesource.com/577495
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/4913e320e82e90b9d076d3db04c899d04d169095

commit 4913e320e82e90b9d076d3db04c899d04d169095
Author: Daniel Kurtz <djkurtz@chromium.org>
Date: Thu Jul 20 07:37:01 2017

dev-python/pyinotify: Update to latest from gentoo

Import the latest pyinotify from upstream gentoo, with the following local
modifications:
 * KEYWORDS=*
 * removed 3_6 from PYTHON_COMPAT

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG= chromium:745353 
TEST=sudo emerge pyinotify
 => Builds ok

Change-Id: I9241bc0c2f6e0b14e82e3118c811abbfa3f94268
Reviewed-on: https://chromium-review.googlesource.com/577495
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/4913e320e82e90b9d076d3db04c899d04d169095/dev-python/pyinotify/Manifest
[modify] https://crrev.com/4913e320e82e90b9d076d3db04c899d04d169095/dev-python/pyinotify/metadata.xml
[add] https://crrev.com/4913e320e82e90b9d076d3db04c899d04d169095/dev-python/pyinotify/pyinotify-0.9.6.ebuild
[delete] https://crrev.com/e3c52cff8f990e8c76a855c4b9701c2a47d5a235/dev-python/pyinotify/pyinotify-0.9.3.ebuild

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/45c39894be9c29534aaeddd964b67ede29967156

commit 45c39894be9c29534aaeddd964b67ede29967156
Author: Michał Górny <mgorny@gentoo.org>
Date: Mon Jul 24 10:03:47 2017

BACKPORT: python-utils-r1.eclass: Enable python3_6 target

(cherry picked from commit 3a4ccfe59e4b0e9795dde8cd8849cbaf19ab9302)
[djkurtz: but keeping python3_3]

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG= chromium:745353 
TEST=./build_packages --board=soraka
TEST=./build_packages --board=hana
TEST=emerge-hana vulkan-loader

Change-Id: I29b7ab0536bd32b882680396b52e2adb820598b9
Reviewed-on: https://chromium-review.googlesource.com/580450
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/45c39894be9c29534aaeddd964b67ede29967156/eclass/python-utils-r1.eclass

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment