Issue metadata
Sign in to add a comment
|
Regression: Weird font is seen on bookmarked url chip while draging url from omnibox.
Reported by
abom...@etouch.net,
Jul 18 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3160.0 (Official Build) 226c080a029bd3ff8a6a577503cefe316c84325b-refs/heads/master@{#487322} 64 bit OS : Windows (7,8,10),Linux What steps will reproduce the problem? 1. Launch chrome,Open Ntp and bookmark it. 2. Navigate to chrome://bookmarks/ and try to drag the 'Secure chrome' chip or URL of omnibox. 3. Observe bookmarked url chip. Actual:Weird font is seen on bookmarked url chip. Expected: Font should be proper on bookmarked url chip. This is regression issue, broken in 'M 61' and below is manual bisect: Good build:61.0.3159.0 Bad build:61.0.3160.0 Note: Issue is not seen on MAC OS.
,
Jul 18 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3159.0(Revision:486995). Bad build:61.0.3160.0(Revision:487322). You are probably looking for a change made after 487227 (known good), but no later than 487228 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/5b7eb518eef51dfbc0fbc05330dfba8994863f92..f6e9c3d9551fb627155335b02583de6d32037646 From the CL above, assigning the issue to the concern owner @reed: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Reviewed-on: https://chromium-review.googlesource.com/572123 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.5 and Able to reproduce in latest Canary #61.0.3160.0
,
Jul 18 2017
I can confirm the bisect results with a local linux build.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b19fa87f981ce227433d03283bf8175d1c29742f commit b19fa87f981ce227433d03283bf8175d1c29742f Author: Christopher Lam <calamity@chromium.org> Date: Mon Jul 24 04:45:18 2017 [MD Bookmarks] Use mouse events for internal drags. This CL separates internal and external drags to use mouse events and native drag respectively. This provides a more reliable internal drag experience, and fixes an issue where the native drag would place a drag image over the bookmark chip. Bug: 739271 , 740857 , 745347 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I930d11e8f063d5483fe4c0f38785eff94c8b1a33 Reviewed-on: https://chromium-review.googlesource.com/576009 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488912} [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/dnd_manager.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/chrome/test/data/webui/md_history/history_synced_tabs_test.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.js [modify] https://crrev.com/b19fa87f981ce227433d03283bf8175d1c29742f/third_party/polymer/v1_0/components_summary.txt
,
Aug 9 2017
,
Aug 9 2017
,
Sep 5
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Jul 18 2017