Issue metadata
Sign in to add a comment
|
Regression:Unnecessary background appears on shelf while downloading a PDF file or saving any page |
||||||||||||||||||||||
Issue descriptionChrome Version:61.0.3159.0/9754.0.0 dev channel Daisy & Minnie OS:Chrome What steps will reproduce the problem? (1)Sign into user ->Launch chrome and open any sample PDF (2)Click on download option of PDF file and Observe the shelf(kindly refer video) OR (1)Launch chrome -> Right click and try to save any page and Observe the shelf Actual:Unnecessary background change appears on Shelf while downloading a PDF file Expected:No such background change should appear on shelf while downloading a PDF file This is a Regression issue as same is working fine in 61.0.3136.5/9672.0.0 dev channel Minnie Note: Issue is not seen in Linux,Windows OS @tdanderson :Please confirm the above issue
,
Jul 18 2017
I believe this regression was caused by[1]. When I revert that patch the bug is fixed. Note that this bug applies to any transient child dialog, for example you can press Ctrl+S for "save page as" and see it. [1] https://codereview.chromium.org/2967543003
,
Jul 18 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/639b61ae53bb47d9de383cec09024c2150f2d47b commit 639b61ae53bb47d9de383cec09024c2150f2d47b Author: muyuanli <muyuanli@chromium.org> Date: Wed Jul 26 19:36:25 2017 fix shelf color with modal dialog. BUG= 745343 TEST=Open save pdf dialog and observe that shelf does not change color. Review-Url: https://codereview.chromium.org/2985453003 Cr-Commit-Position: refs/heads/master@{#489725} [modify] https://crrev.com/639b61ae53bb47d9de383cec09024c2150f2d47b/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/639b61ae53bb47d9de383cec09024c2150f2d47b/ash/wm/focus_rules.cc [modify] https://crrev.com/639b61ae53bb47d9de383cec09024c2150f2d47b/ash/wm/workspace_controller.cc
,
Aug 1 2017
,
Aug 1 2017
Approving merge to M61 Chrome OS.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d113e180640160dac765e9e7c3945918378fb53a commit d113e180640160dac765e9e7c3945918378fb53a Author: Muyuan Li <muyuanli@chromium.org> Date: Wed Aug 02 22:11:42 2017 fix shelf color with modal dialog. BUG= 745343 TEST=Open save pdf dialog and observe that shelf does not change color. TBR=muyuanli@chromium.org (cherry picked from commit 639b61ae53bb47d9de383cec09024c2150f2d47b) Review-Url: https://codereview.chromium.org/2985453003 Cr-Original-Commit-Position: refs/heads/master@{#489725} Change-Id: Ibafc30725c27c236ba42520a2b5ed36912bdfe8b Reviewed-on: https://chromium-review.googlesource.com/598991 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#247} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d113e180640160dac765e9e7c3945918378fb53a/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/d113e180640160dac765e9e7c3945918378fb53a/ash/wm/focus_rules.cc [modify] https://crrev.com/d113e180640160dac765e9e7c3945918378fb53a/ash/wm/workspace_controller.cc
,
Aug 9 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tdander...@chromium.org
, Jul 18 2017Owner: bruthig@chromium.org