New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 745327 link

Starred by 2 users
Status: Fixed
Owner:
leon....@intel.com
Closed: May 2018
Cc:
█ xiaofeng...@intel.com
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 772788
Blocking:
issue 678905



Sign in to add a comment

Fix the ordering between statechange and activate event

Project Member Reported by shimazu@chromium.org, Jul 18 2017 
registration-attribute.https.html/registration-attribute.html are flaky due to the ordering between activate event and statechange event. 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=registration-attribute

According to the failure log, sometimes statechange events are fired after the activate event. It's because of no guarantee of the order between ServiceWorkerMsg_ServiceWorkerStateChanged and ServiceWorkerEventDispatcher::DispatchActivateEvent. This could be problem even after mojoifying methods in SWProvider because there is no guarantee of the ordering between SWProvider and SWEventDispatcher. We have to consider the design of messaging.

Comment 1 by falken@chromium.org, Aug 2 2017

Blocking: 678905

Comment 2 by leon....@intel.com, Aug 15 2017

Cc: -leon....@intel.com
Owner: leon....@intel.com
Will try to figure out how to solve this issue while trying to impl SWContainer(SWProvider) interface.

Comment 3 by leon....@intel.com, Aug 15 2017

Status: Assigned (was: Available)

Comment 4 Deleted

Comment 5 by leon....@intel.com, Nov 9 2017 

Ah, I had a misunderstanding about the event dispatcher Mojo connection, currently it's NOT associated on the legacy IPC channel but just based on a dedicated Mojo message pipe.
So this is still a problem even after 772788 done.

Comment 6 by leon....@intel.com, Nov 9 2017 

SWObject interface will be associated with EmbeddedWorkerInstanceClient interface, which is already associated on the legacy IPC channel.
So, maybe we need to associate the event dispatcher interface with EmbeddedWorkerInstanceClient, too.

Comment 7 by leon....@intel.com, Nov 9 2017 

Now I can't see any special reason which forbids us from associating the event dispatcher interface with EmbeddedWorkerInstanceClient, but seems there is? Any hints? Thanks :)

Comment 8 by shimazu@chromium.org, Nov 10 2017 

Ahh, I've forgotten this issue.. This is a bit complicated.

I don't think we should make SWEventDispatcher associated with EWInstanceClient since all events could be blocked by the main thread congestion if we associate it with SWEventDispatcher.
Basically, I think we need two dedicated pipes, for the main thread (EWInstanceClient) and for the worker thread (SWEventDispatcher). We need to keep control of the worker thread even if the worker thread is busy (continue to run some script on the worker thread, for example). The main thread would control the lifecycle of the worker thread in that case, and in healthy situation, we want to skip the main thread.

I still don't have a good idea for this issue, but I imagine that we need an API to send the state on the worker thread (so it means the message will go through the pipe for SWEventDispatcher), but I haven't looked at it enough.
Could you take a look at this?

Comment 9 by leon....@intel.com, Nov 10 2017 

Oops, I was not aware that the main thread congestion may block associated interfaces on the worker thread...
And, seems this is already a problem now: For SW execution contexts, {SWContainer*,SWRegistrationObject*} running on SW thread are already being associated with EWInstanceClient.

Then, maybe we want to rearrange these interfaces like:
  - EWInstanceClient --> a dedicated Mojo message pipe, its impl runs on main thread. #Although it's associated with legacy IPC channel for now. Tracking at  issue 783071 .
  - SWEventDispatcher and {SWContainer*,SWRegistrationObject*,SWObject*} --> associate all on another dedicated Mojo message pipe, all impls run on SW thread. #Once done this bug will be fixed.

Comment 10 by leon....@intel.com, Mar 18 2018

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf

commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf
Author: Han Leon <leon.han@intel.com>
Date: Wed May 02 04:17:00 2018

[ServiceWorker] Associate interfaces living on the SW thread together

This CL switches those interfaces (ServiceWorkerHost,
ServiceWorkerRegistrationObject[Host] etc.) associated with
EmbeddedWorkerInstanceClient interface before to be associated with
ServiceWorkerEventDispatcher interface living on its particular service
worker thread in the renderer process.
This will not only ensure them keeping the FIFO ordering with
ServiceWorkerEventDispatcher, but also make all their Mojo message
dispatches skip the main thread completely to avoid possible congestion.

The idea is to let browser-side pass ServiceWorkerHost endpoint and
ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call
ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service
worker thread, which holds on evaluating its service worker script until
received that call.

BUG= 745327 , 834200 , 834183 
TBR=lazyboy@chromium.org for enabling a test in
chrome/browser/extensions/service_worker_apitest.cc

Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402
Reviewed-on: https://chromium-review.googlesource.com/981898
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#555307}
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h
[modify] https://crrev.com/8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee

commit d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee
Author: Han Leon <leon.han@intel.com>
Date: Thu May 03 00:33:14 2018

Revert "[ServiceWorker] Associate interfaces living on the SW thread together"

This reverts commit 8aaac4383fc7ddf6e8bb8fd0c5b0ac98bafcecdf.

Reason for revert: crbug.com/838397 and 834200, reland later when we make all things clear

Original change's description:
> [ServiceWorker] Associate interfaces living on the SW thread together
> 
> This CL switches those interfaces (ServiceWorkerHost,
> ServiceWorkerRegistrationObject[Host] etc.) associated with
> EmbeddedWorkerInstanceClient interface before to be associated with
> ServiceWorkerEventDispatcher interface living on its particular service
> worker thread in the renderer process.
> This will not only ensure them keeping the FIFO ordering with
> ServiceWorkerEventDispatcher, but also make all their Mojo message
> dispatches skip the main thread completely to avoid possible congestion.
> 
> The idea is to let browser-side pass ServiceWorkerHost endpoint and
> ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call
> ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service
> worker thread, which holds on evaluating its service worker script until
> received that call.
> 
> BUG= 745327 , 834200 , 834183 
> TBR=lazyboy@chromium.org for enabling a test in
> chrome/browser/extensions/service_worker_apitest.cc
> 
> Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402
> Reviewed-on: https://chromium-review.googlesource.com/981898
> Commit-Queue: Han Leon <leon.han@intel.com>
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Han Leon <leon.han@intel.com>
> Cr-Commit-Position: refs/heads/master@{#555307}

TBR=falken@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,shimazu@chromium.org,leon.han@intel.com

Change-Id: I935bfdbce9b407c937c2e3a5da424773ec397a1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  745327 ,  834200 ,  834183 
Reviewed-on: https://chromium-review.googlesource.com/1041050
Reviewed-by: Han Leon <leon.han@intel.com>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#555630}
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h
[modify] https://crrev.com/d717ddc6ccbabee51b559d0cceaa9f39d2bf78ee/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea53efda17c8c5c3604d56caaa98823a0cc88c20

commit ea53efda17c8c5c3604d56caaa98823a0cc88c20
Author: Han Leon <leon.han@intel.com>
Date: Mon May 14 09:48:44 2018

Reland: [ServiceWorker] Associate interfaces living on the SW thread together

We reverted the original CL
https://chromium-review.googlesource.com/c/chromium/src/+/981898 by
https://chromium-review.googlesource.com/c/chromium/src/+/1041050
because we wanted to solve the crash in bug 838397 immediately at the
time, but after that we have landed its real fix
https://chromium-review.googlesource.com/c/chromium/src/+/1036498,
so now we can reland this one.

The only change from the original CL is that we do not
re-enable the test ServiceWorkerLazyBackgroundTest#EventsAfterRestart in
this CL, because it proved that this CL cannot really solve it, we need
further investigation on it (tracker issue:  834200 ).

BUG= 745327 , 834183 
TBR=shimazu,falken,kinuko

Change-Id: Id5dedfc914b1526af2ea510ef890b768456982cf
Reviewed-on: https://chromium-review.googlesource.com/1056796
Reviewed-by: Han Leon <leon.han@intel.com>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#558241}
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h
[modify] https://crrev.com/ea53efda17c8c5c3604d56caaa98823a0cc88c20/third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc

Comment 14 by leon....@intel.com, May 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment