New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Regression: Text color of avatar icon is not readable.

Reported by avsha...@etouch.net, Jul 18 2017

Issue description

Chrome version : 61.0.3160.0 (Official Build) 226c080a029bd3ff8a6a577503cefe316c84325b-refs/heads/master@{#487322} 64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome, click on Avatar icon and switch into 'Guest' mode.
2. Observe the 'Guest' avatar icon.

Actual Result : Text color of  'Guest' avatar icon is not proper and text is not readable.

Expected Result : Text color of  'Guest' avatar icon should be proper such that the text is easily readable.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3159.0
Bad build : 61.0.3160.0

Note : Above issue can be clearly seen on Win-10 OS.
 
Actual_Result.png
22.4 KB View Download

Comment 1 by avsha...@etouch.net, Jul 18 2017

Correction : 
Above issue is not seen on Linux(14.04), Mac(10.12.3,10.11.6) and Windows 8 OS.
Act_Exp_Results.png
19.0 KB View Download
Cc: reed@chromium.org jmukthavaram@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: reed@google.com
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 using chrome #61.0.3160.0.
Manual bisect info:
-------------------
Good build : 61.0.3159.0-Revision-486995
Bad build : 61.0.3160.0-Revision-487322

Per revision bisect info:
-------------------------
You are probably looking for a change made after 487227 (known good), but no later than 487228 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/5b7eb518eef51dfbc0fbc05330dfba8994863f92..f6e9c3d9551fb627155335b02583de6d32037646

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/f6e9c3d9551fb627155335b02583de6d32037646

reed@Could you please take a look and reassign to the appropriate owner if it is not related to your change.
As it is regressed recently, adding Release block stable label.
Thanks..!!

Summary: Regression: Text color of avatar icon is not readable. (was: Regression : Text color of 'Guest' avatar icon is not proper and text is not readable.)
I don't think this is limited to the Guest profile.
Unreadable.png
7.7 KB View Download
 Issue 745779  has been merged into this issue.

Comment 5 by siggi@chromium.org, Jul 18 2017

Cc: gab@chromium.org
 Issue 745775  has been merged into this issue.

Comment 6 by ew...@chromium.org, Jul 20 2017

Cc: pkasting@chromium.org est...@chromium.org
Adding more folks who have been touching the profile chip recently as FYI
Cc: -pkasting@chromium.org bsep@chromium.org
bsep is the owner of this button now, but it sounds like the suspected issue is a Skia change and we're just waiting on investigation there?
Comment #2 is correct; removing the check for SK_SUPPORT_LEGACY_MASK_BLUR in skblurmask.cpp's BoxBlur function resolves the regression.

An alternative fix in the caller is to change src\chrome\browser\ui\views\profiles\avatar_button.cc's line 422 from

  : gfx::ShadowValues(10, gfx::ShadowValue(gfx::Vector2d(), 
                      2.0f, SK_ColorDKGRAY)));

to

  : gfx::ShadowValues(10, gfx::ShadowValue(gfx::Vector2d(), 
                      3.0f, SK_ColorDKGRAY)));
There may be other minor regressions from the change of the blur behavior; see e.g. 

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc?l=98&rcl=7ab4449310217611922ff7159ba598d063c0bd0a
ShadowDiff.png
52.6 KB View Download
URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Comment 11 by rpop@chromium.org, Jul 31 2017

This should be releaseblock stable, confirmed. Could we have an update on the fix?
Cc: ccameron@chromium.org

Comment 13 by bsep@chromium.org, Aug 1 2017

Cc: emx@chromium.org
 Issue 748575  has been merged into this issue.
Labels: OS-Linux
 Issue 752852  has been merged into this issue.
 Issue 752738  has been merged into this issue.
 Issue 752746  has been merged into this issue.
Cc: ericrk@chromium.org
 Issue 752775  has been merged into this issue.
Cc: hdodda@chromium.org
 Issue 752881  has been merged into this issue.
Just to update, still able to reproduce the issue using #62.0.3180.0 on Win10.

@reed: Is there any latest update's available on this issue as it's tagged with Release Block Stable?

Thanks!!
Cc: rpop@chromium.org
I think we're going to have to attempt to contact reed@ via a different medium than monorail
[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Thank you.

Comment 23 by rpop@chromium.org, Aug 9 2017

I reached out to reed@ via email and cc'd a number of the engineers here. In the future, please don't block on me to get in touch about an urgent bug.

Comment 24 by reed@google.com, Aug 10 2017

Cc: bunge...@chromium.org
Owner: herb@chromium.org
Cc: robliao@chromium.org

Comment 26 by herb@google.com, Aug 10 2017

Reviewing bug https://bugs.chromium.org/p/chromium/issues/detail?id=624175, I noticed that it talks about the shadow being too wide by twice compared to the CSS spec. The code had a blur_ / 2.0 in order to compensate. Now that the SkMaskBlur obeys the CSS/SVG spec, the 1/2 factor is not needed. The above code approximates this by changing the 2.0 to 3.0. The many twists and turns the code takes to go from blur_ (shadow radius) to sigma should be reevaluated.
Are you saying that everywhere that uses CreateShadowDrawLooper now looks different than it did before the skia change?

Comment 28 by herb@google.com, Aug 10 2017

I think so. The new code obeys the CSS/SVG shadow algorithm. In the looper, I think that the shadow.blur()/2 is a compensation for the old SkMaskBlurFilter code. The new SkBlurMaskFilter code now behaves the same as SkBlurImageImage, and both should obey the spec.

Comment 29 by rpop@chromium.org, Aug 10 2017

Cc: ew...@chromium.org pkasting@chromium.org
 Issue 754271  has been merged into this issue.
Cc: pbomm...@chromium.org
 Issue 754566  has been merged into this issue.
 Issue 755010  has been merged into this issue.
 Issue 755011  has been merged into this issue.

Comment 33 by wfh@chromium.org, Aug 14 2017

FWIW this is still happening for me in Chrome Canary 62.0.3185.0
We'll make sure to tag this bug with any CL that fixes it.

Comment 35 by ew...@chromium.org, Aug 14 2017

Cc: msarda@chromium.org jlebel@chromium.org droger@chromium.org bsazonov@chromium.org
 Issue 750670  has been merged into this issue.
Project Member

Comment 36 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/df33fefe14837d7a7130aacb6206dbe3ebc7d081

commit df33fefe14837d7a7130aacb6206dbe3ebc7d081
Author: Herb Derby <herb@google.com>
Date: Mon Aug 14 19:16:55 2017

Test blur small radii and text.

BUG= chromium:745290 

Change-Id: I78cabf988115598e14a7ce39faf96e3a697a1a8f
Reviewed-on: https://skia-review.googlesource.com/34382
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/df33fefe14837d7a7130aacb6206dbe3ebc7d081/gn/gm.gni
[add] https://crrev.com/df33fefe14837d7a7130aacb6206dbe3ebc7d081/gm/blurtextsmallradii.cpp

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ba8275148ab8b10393b053e2586b852796c4afc2

commit ba8275148ab8b10393b053e2586b852796c4afc2
Author: Herb Derby <herb@google.com>
Date: Mon Aug 14 20:20:55 2017

Add an average mode for sigma < 2

The original code had an optimization when sigma < 2 that averaged
pixels instead of Gaussian bluring them. This CL adds that
behavior back to the new implementat.

BUG= chromium:745290 
Change-Id: I35b7de2138a859d546439cc2053b4b599a94ebe1
Reviewed-on: https://skia-review.googlesource.com/34180
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/ba8275148ab8b10393b053e2586b852796c4afc2/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/ba8275148ab8b10393b053e2586b852796c4afc2/src/core/SkMaskBlurFilter.h

Status: Fixed (was: Assigned)
The CL on comment 37 is the fix, tested locally in Chrome and our new test as seen in comment 36.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-61
Project Member

Comment 41 by sheriffbot@chromium.org, Aug 14 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls update the bug with Canary result once change list at #37 is baked/verified in Canary. Also will this be a safe merge and having enough automation tests coverage?
Labels: -Merge-TBD
Yes, we'll ping the bug in a couple days when we see Canary fixed.

We've gone from 0 tests to 1 test in Skia, so we're kind of infinitely better now.  I'm not aware of automated testing on the Chrome UI like we have for Blink layout tests.
Ok, sounds good. Thank you mtklein@.
Project Member

Comment 46 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/8e7503195c40492df6a9c072d3303c9df9ec32dc

commit 8e7503195c40492df6a9c072d3303c9df9ec32dc
Author: Mike Klein <mtklein@google.com>
Date: Tue Aug 15 12:47:27 2017

Revert "Add an average mode for sigma < 2"

This reverts commit ba8275148ab8b10393b053e2586b852796c4afc2.

Reason for revert: layout tests, Google3 equivalent failing.

Original change's description:
> Add an average mode for sigma < 2
> 
> The original code had an optimization when sigma < 2 that averaged
> pixels instead of Gaussian bluring them. This CL adds that
> behavior back to the new implementat.
> 
> BUG= chromium:745290 
> Change-Id: I35b7de2138a859d546439cc2053b4b599a94ebe1
> Reviewed-on: https://skia-review.googlesource.com/34180
> Commit-Queue: Herb Derby <herb@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com

Change-Id: Ie8f38b042acec42260913cb7bed5538a2c957e9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:745290 
Reviewed-on: https://skia-review.googlesource.com/34640
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/8e7503195c40492df6a9c072d3303c9df9ec32dc/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/8e7503195c40492df6a9c072d3303c9df9ec32dc/src/core/SkMaskBlurFilter.h

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6573882a8924b04644910dc3cf42a790cdb01d39

commit 6573882a8924b04644910dc3cf42a790cdb01d39
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Tue Aug 15 14:25:41 2017

Roll src/third_party/skia/ 17e33cc7b..8e7503195 (12 commits)

https://skia.googlesource.com/skia.git/+log/17e33cc7b029..8e7503195c40

$ git log 17e33cc7b..8e7503195 --date=short --no-merges --format='%ad %ae %s'
2017-08-15 mtklein Revert "Add an average mode for sigma < 2"
2017-08-11 kjlubick Add upload to task name schema file
2017-08-15 skia-deps-roller Roll skia/third_party/externals/angle2/ d93cd6c23..78ed6cd9e (1 commit)
2017-08-14 skia-deps-roller Roll skia/third_party/externals/angle2/ d7487b135..d93cd6c23 (1 commit)
2017-08-14 fmalita Lowp overlay, hardlight stages
2017-08-14 brianosman Switch SkSL to std::string
2017-08-14 herb Add an average mode for sigma < 2
2017-08-14 skia-deps-roller Roll skia/third_party/externals/angle2/ 9b11ea4f2..d7487b135 (1 commit)
2017-08-14 benjaminwagner Upgrade NVIDIA drivers on Linux bots.
2017-08-10 bungeman Move lang to list in Android font manager.
2017-08-14 herb Test blur small radii and text.
2017-08-14 robertphillips Use kLow_SkFilterQuality in generateGlyphImage

Created with:
  roll-dep src/third_party/skia
BUG= 745290 , 745290 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I8846fe1297bba94e48b5abccb156418ec9be9b35
Reviewed-on: https://chromium-review.googlesource.com/615016
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494376}
[modify] https://crrev.com/6573882a8924b04644910dc3cf42a790cdb01d39/DEPS

Status: Started (was: Fixed)
Note that roll in Comment 47 contains both the fix and its revert.  We'll need to reland it in a more careful way so that we can rebaseline changes to Blink layout tests.
Project Member

Comment 49 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/f6975ea5fb178c572cf4c1cd255e5fe623418d45

commit f6975ea5fb178c572cf4c1cd255e5fe623418d45
Author: Herb Derby <herb@google.com>
Date: Tue Aug 15 15:00:17 2017

Revert "Revert "Add an average mode for sigma < 2""

We are going to have the google3 auto roller build the CL,
and add the fixes to the failing tests to that CL. Because
these are scuba changes, this should be simpler.

This reverts commit 8e7503195c40492df6a9c072d3303c9df9ec32dc.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Add an average mode for sigma < 2"
> 
> This reverts commit ba8275148ab8b10393b053e2586b852796c4afc2.
> 
> Reason for revert: layout tests, Google3 equivalent failing.
> 
> Original change's description:
> > Add an average mode for sigma < 2
> > 
> > The original code had an optimization when sigma < 2 that averaged
> > pixels instead of Gaussian bluring them. This CL adds that
> > behavior back to the new implementat.
> > 
> > BUG= chromium:745290 
> > Change-Id: I35b7de2138a859d546439cc2053b4b599a94ebe1
> > Reviewed-on: https://skia-review.googlesource.com/34180
> > Commit-Queue: Herb Derby <herb@google.com>
> > Reviewed-by: Mike Klein <mtklein@chromium.org>
> 
> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com
> 
> Change-Id: Ie8f38b042acec42260913cb7bed5538a2c957e9b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  chromium:745290 
> Reviewed-on: https://skia-review.googlesource.com/34640
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com

Change-Id: I5f7b706a2f8c8d52b3576c638ecddf12a1652031
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:745290 
Reviewed-on: https://skia-review.googlesource.com/34641
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>

[modify] https://crrev.com/f6975ea5fb178c572cf4c1cd255e5fe623418d45/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/f6975ea5fb178c572cf4c1cd255e5fe623418d45/src/core/SkMaskBlurFilter.h

Project Member

Comment 50 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4009668cb828b2a0647b8316fa00af2980cf21d3

commit 4009668cb828b2a0647b8316fa00af2980cf21d3
Author: Herb Derby <herb@google.com>
Date: Tue Aug 15 15:09:57 2017

Revert "Revert "Revert "Add an average mode for sigma < 2"""

This reverts commit f6975ea5fb178c572cf4c1cd255e5fe623418d45.

Reason for revert:
Did not take into account there are layout test problems too. Adding a legacy flag.

Original change's description:
> Revert "Revert "Add an average mode for sigma < 2""
> 
> We are going to have the google3 auto roller build the CL,
> and add the fixes to the failing tests to that CL. Because
> these are scuba changes, this should be simpler.
> 
> This reverts commit 8e7503195c40492df6a9c072d3303c9df9ec32dc.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Add an average mode for sigma < 2"
> > 
> > This reverts commit ba8275148ab8b10393b053e2586b852796c4afc2.
> > 
> > Reason for revert: layout tests, Google3 equivalent failing.
> > 
> > Original change's description:
> > > Add an average mode for sigma < 2
> > > 
> > > The original code had an optimization when sigma < 2 that averaged
> > > pixels instead of Gaussian bluring them. This CL adds that
> > > behavior back to the new implementat.
> > > 
> > > BUG= chromium:745290 
> > > Change-Id: I35b7de2138a859d546439cc2053b4b599a94ebe1
> > > Reviewed-on: https://skia-review.googlesource.com/34180
> > > Commit-Queue: Herb Derby <herb@google.com>
> > > Reviewed-by: Mike Klein <mtklein@chromium.org>
> > 
> > TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com
> > 
> > Change-Id: Ie8f38b042acec42260913cb7bed5538a2c957e9b
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  chromium:745290 
> > Reviewed-on: https://skia-review.googlesource.com/34640
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Commit-Queue: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com
> 
> Change-Id: I5f7b706a2f8c8d52b3576c638ecddf12a1652031
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  chromium:745290 
> Reviewed-on: https://skia-review.googlesource.com/34641
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Herb Derby <herb@google.com>

TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com

Change-Id: I9064f8494e5a1a4a78dd545697e22f52985c0fa1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:745290 
Reviewed-on: https://skia-review.googlesource.com/34623
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>

[modify] https://crrev.com/4009668cb828b2a0647b8316fa00af2980cf21d3/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/4009668cb828b2a0647b8316fa00af2980cf21d3/src/core/SkMaskBlurFilter.h

[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62.

Project Member

Comment 52 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c324a62e197bc4cf196e2c78c1a527b207bbaaf1

commit c324a62e197bc4cf196e2c78c1a527b207bbaaf1
Author: Herb Derby <herb@google.com>
Date: Tue Aug 15 18:31:38 2017

Add SK_SUPPORT_LEGACY_USE_GAUSS_FOR_SMALL_RADII

NOTRY=TRUE
R=fmalita@google.com

BUG= 745290 

Change-Id: I3e9f662bb11e700ff422b37737a3417989307ef6
Reviewed-on: https://chromium-review.googlesource.com/615522
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494456}
[modify] https://crrev.com/c324a62e197bc4cf196e2c78c1a527b207bbaaf1/skia/config/SkUserConfig.h

Project Member

Comment 53 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc

commit 15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc
Author: Herb Derby <herb@google.com>
Date: Tue Aug 15 18:55:59 2017

Add an average mode for sigma < 2

The original code had an optimization when sigma < 2 that averaged
pixels instead of Gaussian bluring them. This CL adds that
behavior back to the new implementation.

Add the flag SK_LEGACY_USE_GAUSS_FOR_SMALL_RADII to control the
new behavior.

BUG= chromium:745290 

Change-Id: I6e7417ce7f42949f88376b549743a9f047667f09
Reviewed-on: https://skia-review.googlesource.com/34624
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc/src/core/SkMaskBlurFilter.h

Project Member

Comment 54 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a90d7b59a6bdcdcdccfe95e369ba8918e9e32f9

commit 9a90d7b59a6bdcdcdccfe95e369ba8918e9e32f9
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Tue Aug 15 21:02:05 2017

Roll src/third_party/skia/ 057981388..15bb26ec7 (5 commits)

https://skia.googlesource.com/skia.git/+log/057981388d74..15bb26ec70c9

$ git log 057981388..15bb26ec7 --date=short --no-merges --format='%ad %ae %s'
2017-08-15 herb Add an average mode for sigma < 2
2017-08-15 brianosman Don't emit CRLF when generating code on Windows (from SkSL)
2017-08-15 skia-deps-roller Roll skia/third_party/externals/angle2/ 79f7104ab..aadc8f376 (1 commit)
2017-08-15 kjlubick Add tasks for Acer R13
2017-08-15 benjaminwagner Upgrade GT610 drivers.

Created with:
  roll-dep src/third_party/skia
BUG= 745290 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I6c1aa9ba6fcf42aff88af2f16dbac1710e542e46
Reviewed-on: https://chromium-review.googlesource.com/615860
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494540}
[modify] https://crrev.com/9a90d7b59a6bdcdcdccfe95e369ba8918e9e32f9/DEPS

For clarity, is the old (and now re-added) behavior reasonable and correct, or is it basically a hack that the code came to depend on?  If the latter, then maybe this is a good short-term fix, but we should be changing callers to do something else so we can ultimately remove this again?
That's something we've yet to determine, but we're leaning toward a hack we've come to depend on.

It'd certainly be reasonable for us to split our current blur effect in two, one always box blurring, the other always gaussian, and then call site by call site we can decide which of the blur algorithms to use.  The old status quo and this re-added behavior couple that choice to blur radius, which we find somewhat bizarre.
I agree with your instinct that tying this to blur radius is surprising.  Exposing an explicit method switch might work.  We may also want to evaluate whether some of the callers currently using blur should really be blurring at all.  Both the cases noted in this bug (text outlining, line below toolbar) are ones where I don't think a blur is really a good choice for our UX.  Perhaps if we eliminate people who rely on the precise details of the method, we won't need a way to precisely specify the method.

In any case, there should probably be some plan that tracks "get to a point where we don't just make this switch automatically at radius 2".
Project Member

Comment 58 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0d2d4af840fbd861d6e4444346c90c67dede13

commit 8a0d2d4af840fbd861d6e4444346c90c67dede13
Author: Herb Derby <herb@google.com>
Date: Wed Aug 16 03:59:53 2017

Start using linear filter for small sigma


BUG= chromium:745290 

Change-Id: I993b392b1fe59f3ee5c91636561cd33dcfab589e
Reviewed-on: https://chromium-review.googlesource.com/616018
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494691}
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/skia/config/SkUserConfig.h
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/fast/box-shadow/single-pixel-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-split-inline-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/basic-shadows-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/inset-box-shadows-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/inset-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/box-shadow/inset-subpixel-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/css/color-correction-on-text-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/month-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/week-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/checkbox/checkbox-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/radio/radio-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/range/range-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/text-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/textarea/textarea-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-edge-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-iframe-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-rtl-ui-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/text/shadow-translucent-fill-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/text/textshadow-001-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/text/textshadow-002-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/text/textshadow-003-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/text/textshadow-004-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/text/textshadow-010-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/paint/roundedrects/circle-with-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/paint/roundedrects/input-with-rounded-rect-and-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/transforms/shadows-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/color-correction-on-text-shadow-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/month-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/week-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/text-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/textarea/textarea-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-edge-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-iframe-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/validation-bubble-appearance-rtl-ui-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/shadow-translucent-fill-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/ietestcenter/css3/text/textshadow-002-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/ietestcenter/css3/text/textshadow-003-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/ietestcenter/css3/text/textshadow-004-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/ietestcenter/css3/text/textshadow-010-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/css/text-shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/month-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/week-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/week-picker-appearance-step-expected.png
[add] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/checkbox/checkbox-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
[add] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/radio/radio-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/submit/submit-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/text-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/textarea/textarea-appearance-basic-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-edge-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-iframe-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/validation-bubble-appearance-rtl-ui-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/box-shadow/basic-shadows-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/shadow-multiple-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/month-picker-appearance-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/month-picker-appearance-step-expected.png
[modify] https://crrev.com/8a0d2d4af840fbd861d6e4444346c90c67dede13/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms
Update :
Tested this issue in latest chrome build #62.0.3187.0 on Windows(7,10) OS and issue is still reproducible. Kindly review an attached screenshot.

Thank you! 
Actual_Result.png
7.3 KB View Download

Comment 60 by herb@chromium.org, Aug 16 2017

The version you checked did not have the fix.

Comment 61 by herb@chromium.org, Aug 16 2017

Labels: Merge-Request-61
The cl that fixes this behavior is https://skia-review.googlesource.com/c/34624

This was rolled into head at #54, and turned on in #58.
Cc: abdulsyed@chromium.org
Sorry, I'm little confused here.So please answer followings before merge approval:
* This seems to be M61 regression and Release block stable per comment #11.
* Which CLs need to be merged to M61 as multiple CLs are listed in this bug?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.

Please note We're only few weeks away from M61 Stable promotion, so merge bar is VERY high. Thank you.



This only relanded last night, so it's not baked in Canary.  No one has looked at Canary yet.

When you ask us to merge, we're going to merge "Add an average mode for sigma < 2" into Skia's M61 branch.  There have been a two uninterestingly different variants of that CL landed, the second with #define guards than let us roll it into Chrome without breaking Blink's layout tests.  We could merge either into the M61 branch with the same effect.

Herb's out until Tuesday, so if it can wait until then that's the day we'd like to merge into M61.
Labels: -Merge-Request-61
NextAction: 2017-08-18
Thank you  mtklein@. Please update the bug with Canary result. 
Labels: TE-Verified-M62 TE-Verified-62.0.3188.0
Update : 
Retested above issue in latest chrome canary #62.0.3188.0 on Win(7,10) OS and issue is not reproducible. Issue is fixed now and it is working as intended.
Kindly review an attached screen shot.

Thank you!

Canary_Results.png
3.7 KB View Download
Issue 756264 has been merged into this issue.
The NextAction date has arrived: 2017-08-18
mtklein@, how is the change looking in Canary so far?

Comment 70 by wfh@chromium.org, Aug 18 2017

not sure if this is the same issue or different (I am happy to raise another bug) but I am seeing the same sort of rendering issues on chrome native dialog boxes. See attached screenshot.

To repro, open a new tab, and type:

javascript:alert()

into the URL bar.
alert_dialog.png
2.7 KB View Download
Re #70: estade just checked in that fix for buttons not painting backgrounds. 

Comment 72 by herb@google.com, Aug 21 2017

Prepared CL: https://skia-review.googlesource.com/c/36542 for merge into m61.

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for cl listed at #72 to M61 branch 3163. Please merge ASAP. Thank you.
[Bulk Edit]
URGENT - PTAL.
M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. 

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62. Thank you!

Note: We will only have 2 beta releases before Stable promotion. Plan is to cut M61 Stable RC on 08/31/17.

Project Member

Comment 75 by bugdroid1@chromium.org, Aug 21 2017

Labels: merge-merged-m61
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ffc2b06a73b0b3d560d831e57723e4c579a56315

commit ffc2b06a73b0b3d560d831e57723e4c579a56315
Author: Herbert Derby <herb@google.com>
Date: Mon Aug 21 16:10:09 2017

Cherry-pick 15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc into origin/chrome/m61.

Add an average mode for sigma < 2

The original code had an optimization when sigma < 2 that averaged
pixels instead of Gaussian bluring them. This CL adds that
behavior back to the new implementation.

Add the flag SK_LEGACY_USE_GAUSS_FOR_SMALL_RADII to control the
new behavior.

BUG= chromium:745290 

Cherry-Pick: 15bb26ec70c9df6dbfc259918d9d9b0d8b2fcccc
Approval: 745290
No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Change-Id: I26b41990be894d2cec6ee75627dfae6068ede350
Reviewed-on: https://skia-review.googlesource.com/36542
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>

[modify] https://crrev.com/ffc2b06a73b0b3d560d831e57723e4c579a56315/src/core/SkMaskBlurFilter.cpp
[modify] https://crrev.com/ffc2b06a73b0b3d560d831e57723e4c579a56315/src/core/SkMaskBlurFilter.h

Comment 76 by herb@google.com, Aug 21 2017

Labels: -Merge-Approved-61 Merge-Merged
Labels: -Merge-Merged merge-merged-3163

Comment 78 by herb@chromium.org, Aug 22 2017

Cc: -droger@chromium.org herb@chromium.org

Comment 79 by herb@chromium.org, Aug 22 2017

Cc: -abdulsyed@chromium.org droger@chromium.org
Status: Fixed (was: Started)

Comment 80 by herb@chromium.org, Aug 22 2017

Cc: -droger@chromium.org abdulsyed@chromium.org

Sign in to add a comment