Regression : Delete icon is missing on chrome://settings/content/cookies.
Reported by
pranjali...@etouch.net,
Jul 18 2017
|
||||||||||||
Issue descriptionChrome Version: 61.0.3160.0 (Official Build) (cohort: Stable)226c080a029bd3ff8a6a577503cefe316c84325b-refs/heads/master@{#487322} (32/64-bit) OS: Windows (7,8,10). Steps to reproduce: 1)Launch Chrome go to chrome://settings/content/cookies, scroll down and observe. Actual Result :Delete icon is missing for Cookies. Expected Result :Delete icon should be seen. This is Regression issue broken in 'M-61' and will soon update the bisect info. Manual bisect info : Good Build:61.0.3159.0 Bad Build :61.0.3160.0 Note: Will update Mac and Linux status once build is available.
,
Jul 18 2017
Able to reproduce the issue on Windows 7,ubuntu 14.04 & Mac 10.12.5 using chrome latest Canary-61.0.3159.0. Manual bisect info: ------------------- Good Build:61.0.3159.0-Revision-486995 Bad Build :61.0.3160.0-Revision-487322 Per revision bisect info: ------------------------ You are probably looking for a change made after 487124 (known good), but no later than 487125 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/61afb80b65c8d5c7e5c4dfadcb25b1a6fd4357e3..ef1ed17bc5fbe990cd350fc73077c3deeb6a2355 Possible suspect: ----------------- https://chromium.googlesource.com/chromium/src/+/ef1ed17bc5fbe990cd350fc73077c3deeb6a2355 stevenjb@Could you please take a look and reassign to the right owner if it is not related to your change. As it is a recent regression broken in M61, adding Release block stable label.Please remove if not the case. Thanks..!!
,
Jul 18 2017
The referenced change is unrelated. ->dschuyler@ to investigate or assign.
,
Jul 19 2017
CL at https://chromium-review.googlesource.com/c/576969/
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94d1984c3fc2106c2398540e9b3435631fe5b80e commit 94d1984c3fc2106c2398540e9b3435631fe5b80e Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Jul 21 01:37:10 2017 [MD settings] change icon-delete to a -gray and -white version This CL splits the icon-delete svg into icon-delete-gray and icon-delete-white so that we have two colors to use. TBR=tommycli@chromium.org Bug: 745289 Change-Id: I4d28034520eded8f787ee605bbb0da22f252d698 Reviewed-on: https://chromium-review.googlesource.com/576969 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#488540} [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/browser/resources/settings/device_page/storage.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/browser/resources/settings/people_page/fingerprint_list.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/chrome/test/data/webui/settings/site_data_test.js [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/ui/webui/resources/cr_elements/cr_icons_css.html [modify] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/ui/webui/resources/cr_elements_images.grdp [add] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/ui/webui/resources/images/icon_delete_gray.svg [rename] https://crrev.com/94d1984c3fc2106c2398540e9b3435631fe5b80e/ui/webui/resources/images/icon_delete_white.svg
,
Jul 21 2017
,
Jul 21 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 21 2017
,
Jul 21 2017
,
Jul 22 2017
This bug requires manual review: There is .grd file changes and we are only 44 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 24 2017
dschuyler@, before we approve merge to M61, could you please confirm CL listed at #5 is well baked/verified in Canary and will be a safe merge to M61?
,
Jul 25 2017
The fix is present in Chrome Canary Version 62.0.3T66.0 on MacOS. I searched crbug for any new bugs with "trash icon" or "delete icon" and didn't see anything recent.
,
Jul 25 2017
#12 by "the fix is present" I mean that the bug doesn't repro in that build.
,
Jul 26 2017
Rechecked this issue on Windows 10, Mac 10.12.5, Ubuntu 14.04 using chrome version 62.0.3167.0 and fix is working as expected. Delete icon is displayed on page chrome://settings/content/cookies. Attached screen shot for the same and adding TE-verified labels. Thanks.!
,
Jul 26 2017
Approving merge to M61 branch 3163 based on comment #13 and #14. Please merge ASAP. Thank you.
,
Jul 26 2017
Pls merge you change to M61 branch 3163 by 5:00 PM today, Wednesday if possible so we can take it in for next week M61 last dev release. Thank you.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48665a90f297c1ff40b6db94bad46988158a7591 commit 48665a90f297c1ff40b6db94bad46988158a7591 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jul 26 20:14:49 2017 [MD settings] change icon-delete to a -gray and -white version This CL splits the icon-delete svg into icon-delete-gray and icon-delete-white so that we have two colors to use. TBR=dschuyler@chromium.org, tommycli@chromium.org (cherry picked from commit 94d1984c3fc2106c2398540e9b3435631fe5b80e) Bug: 745289 Change-Id: I4d28034520eded8f787ee605bbb0da22f252d698 Reviewed-on: https://chromium-review.googlesource.com/576969 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488540} Reviewed-on: https://chromium-review.googlesource.com/587421 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#66} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/browser/resources/settings/device_page/storage.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/browser/resources/settings/people_page/fingerprint_list.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/chrome/test/data/webui/settings/site_data_test.js [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/ui/webui/resources/cr_elements/cr_icons_css.html [modify] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/ui/webui/resources/cr_elements_images.grdp [add] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/ui/webui/resources/images/icon_delete_gray.svg [rename] https://crrev.com/48665a90f297c1ff40b6db94bad46988158a7591/ui/webui/resources/images/icon_delete_white.svg |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by pranjali...@etouch.net
, Jul 18 201764.2 KB
64.2 KB View Download