Issue metadata
Sign in to add a comment
|
Decide which permission types to use modal prompts for on Android |
||||||||||||||||||||||||
Issue descriptionAssuming we switch to modals on Android we need to decide which types of prompts to do it for. The full list is: QUOTA, DOWNLOAD, PERMISSION_GEOLOCATION, PERMISSION_MIDI_SYSEX, PERMISSION_NOTIFICATIONS, PERMISSION_PROTECTED_MEDIA_IDENTIFIER, PERMISSION_MEDIASTREAM_MIC, PERMISSION_MEDIASTREAM_CAMERA, It would be architecturally simpler if we could use modals for everything unless there's a strong reason not to. emilyschechter: Do you have any thoughts on this? Quota and Automatic Download prompts are very rare so it might not matter so much for those.
,
Jul 28 2017
Actually the download prompt UI is a bit shaky, assuming permission.site is representative we should probably either fix it or leave it with infobars for now... The order you action prompts is now reversed. Even if you block the permission, you still have to action the infobar and can actually still download the file.
,
Jul 28 2017
,
Jul 28 2017
I agree it would be best to make all modals. I'm a bit confused about the download prompt UI but can you add it to the deck so we have everything in one place?
,
Jul 28 2017
I'm confused about the current state of the download prompt UI. It seems like it's something we need to fix in general. * "Do you want to let this site download multiple files" seems quite different to me than "automatic downloads" which shows up in PageInfo. Are these the same thing? * Is the current state that we have 2 infobars one after another, (1) is "do you want to allow multiple downloads" like c#3 but an infobar, and then if you say allow, we give you another infobar "do you want to download this file again" like c#2? But you're saying now that's reversed? cc +dalhke/rachelis in case they're looking at this prompt
,
Jul 28 2017
Thanks for the feedback. Yes, we are looking at this, but don't have definitive plans yet, so the timing is very good. The infobar about downloading this file again is totally unrelated to the multiple downloads infobar. Users receive that prompt whenever they are downloading a file that is already on disk. The reason why this shows up in this particular case is because the way permission.site pushes the prompt is that it downloads two files with the same name (which wouldn't happen under any normal circumstances). As for "automatic download" actually being multiple downloads, I agree this is wonky. We do have a real problem with sites automatically downloading files without user interaction and we are working on the HTML spec side to limit that (no downloads from sandboxed iframes, downloads from other iframes require delegation). I wasn't planning on using a site permission, but that is something we could consider. At minimum, we should probably change the name to Multiple downloads if we are going to keep the current permission. Other thoughts?
,
Jul 31 2017
Thanks for explaining dahlke :) > (no downloads from sandboxed iframes, downloads from other iframes require delegation) Cool sounds good. In case you haven't seen, there is something called Feature Policy that makes doing the delegation part consistent and easy.
,
Aug 8 2017
Thanks for the explanation @dahlke. I suggest in the short term to rename the permission "multiple downloads" and change the dialog text to be more inline with our other permissions - "site.com wants to download multiple files. BLOCK ALLOW"
,
Nov 6 2017
timloh: is the "deciding" part of this bug finished now given that modals are shipping in M63?
,
Nov 6 2017
Deciding is done (using modals for everything). |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by timloh@chromium.org
, Jul 18 2017