New issue
Advanced search Search tips

Issue 745233 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Add page for credits/third party contributions

Project Member Reported by yuweih@chromium.org, Jul 18 2017 
Add a Credits button in the help center view to show the credits page.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/994823a0b148527950a25e478252a5d1455a264d

commit 994823a0b148527950a25e478252a5d1455a264d
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Jul 18 21:52:57 2017

[CRD iOS] Add the credits page

This CL:

* Makes the build target generate the credits page for the app.
* Adds the credits page to the help view.

Bug:  745233 
Change-Id: Id612c7140fbdcc9433854d26f8c33509c28ac3c2
Reviewed-on: https://chromium-review.googlesource.com/575041
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487620}
[modify] https://crrev.com/994823a0b148527950a25e478252a5d1455a264d/remoting/ios/app/BUILD.gn
[modify] https://crrev.com/994823a0b148527950a25e478252a5d1455a264d/remoting/ios/app/app_delegate.mm
[add] https://crrev.com/994823a0b148527950a25e478252a5d1455a264d/remoting/ios/app/help_view_controller.h
[add] https://crrev.com/994823a0b148527950a25e478252a5d1455a264d/remoting/ios/app/help_view_controller.mm
[modify] https://crrev.com/994823a0b148527950a25e478252a5d1455a264d/remoting/ios/app/remoting_ios_tmpl.gni

Comment 2 by yuweih@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Sep 23 2017

Status: Verified (was: Fixed)
Verified in 63.0.3220.0
►

Sign in to add a comment