New launcher has different behaviors when click "close x" or "backspace" in HALF mode. |
||||||
Issue descriptionIn the PEEKING mode, tying something to search. It will expand the launcher from PEEKING mode to HALF. This time, when you use "backspace" to delete all the text, it will go back to PEEKING. However, if you click "close x" button, it will still in HALF mode.
,
Jul 18 2017
,
Jul 18 2017
Weidong@, this is related to 735499, would you mind taking it?
,
Jul 18 2017
Sure, I thought it was intended behavior to only clear search box. So it should have the same behavior as that triggered by backspace?
,
Jul 18 2017
Yes, same behavior because we aren't implementing 0 query state until V2.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33a125276dcaa92d894b6109541e3b91cab1bb66 commit 33a125276dcaa92d894b6109541e3b91cab1bb66 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Jul 19 20:58:00 2017 Fix close button wrong behavior in HALF mode Changes: 1. Makes the launcher go back to PEEKING state when you click close button in HALF mode. 2. Modifies the corresponding unit test. BUG= 745156 TEST=SearchBoxViewFullscreenTest.CloseButtonTest Change-Id: I12b6743cdf49ddbac254004d053d60db2df602e5 Reviewed-on: https://chromium-review.googlesource.com/576115 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487971} [modify] https://crrev.com/33a125276dcaa92d894b6109541e3b91cab1bb66/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/33a125276dcaa92d894b6109541e3b91cab1bb66/ui/app_list/views/search_box_view.h [modify] https://crrev.com/33a125276dcaa92d894b6109541e3b91cab1bb66/ui/app_list/views/search_box_view_unittest.cc
,
Jul 19 2017
,
Jul 25 2017
Verified on M62 (dev) build. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wutao@chromium.org
, Jul 18 2017