New issue
Advanced search Search tips

Issue 745114 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 762899
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Blurry text under border-radius

Project Member Reported by chrishtr@chromium.org, Jul 18 2017

Issue description

Version: 61.0.3157.3

Load the attached testcase on a retina screen Mac. Text will be blurry.
It has something to do with the border-radius mask.
 
test.html
91 bytes View Download
Cc: jmukthavaram@chromium.org
Labels: -Type-Bug -Needs-Bisect hasbisect-per-revision Type-Bug-Regression
Owner: sunxd@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac Retina 10.12.5 using chrome latest Canary-61.0.3159.0 as per the above html file.
Manual bisect info:
-------------------
Good-61.0.3151.4-Revision-484781
Bad-61.0.3152.0-Revision-485105

Per revision bisect info:
------------------------
You are probably looking for a change made after 485039 (known good), but no later than 485040 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/5e67601472f51e96298b2b4edfa7286470bf8865..06adb5e74eb341b5a1fa68fed4e489f6f62ec5e8

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/06adb5e74eb341b5a1fa68fed4e489f6f62ec5e8

sunxd@Could you please take a look and reassign to the right owner if it is not related to your change.

Note:
No issue observed on Windows 7,ubuntu 14.04 & Mac book air.

Thanks..!!

Comment 2 by ajha@chromium.org, Jul 24 2017

Friendly ping to get an update on this.

Comment 3 by sunxd@chromium.org, Jul 25 2017

It's very likely a scroll snapping bug, I'm going to revert the border-radius scrolling change.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2397e783b2b5a59a174d25d26f66d467a8b0a88f

commit 2397e783b2b5a59a174d25d26f66d467a8b0a88f
Author: sunxd <sunxd@chromium.org>
Date: Tue Jul 25 23:17:07 2017

Revert "cc: Enable composited border-radius scrolling."

This reverts commit 06adb5e74eb341b5a1fa68fed4e489f6f62ec5e8.

Reason for revert: Composited border-radius scrolling triggers two regression bugs: 1)  crbug.com/740720 , it results in high memory usage probably due to mask tiling not saving enough memory; 2)  crbug.com/745114 , compositor's scroll snapping can sometimes result in blurry text.

Original change's description:
> cc: Enable composited border-radius scrolling.
> 
> Enable composited border-radius scrolling as mask tiling is implemented.
> We'll revert this CL if anything breaks.
> 
> Bug:  567293 ,  567296 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I70bea4c542e00d244a597d1a36857dd120fc96cd
> Reviewed-on: https://chromium-review.googlesource.com/543397
> Commit-Queue: Xianda Sun <sunxd@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485040}

TBR=flackr@chromium.org,trchen@chromium.org,chrishtr@chromium.org,enne@chromium.org,sunxd@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  567293 ,  567296 ,  740720 ,  745114 
Change-Id: Ia185a9ce4310aeaff0175f0e9f0a9080dccf22e5
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/585227
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489477}
[add] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.html
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.txt
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius-expected.txt
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-border-radius-clipping-expected.png
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac-mac10.9/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac/scrollbars/border-box-rect-clips-scrollbars-expected.png
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-border-radius-clipping-expected.png
[delete] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/2397e783b2b5a59a174d25d26f66d467a8b0a88f/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

Comment 5 by sunxd@chromium.org, Jul 26 2017

Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression -M-61 Pri-2 Type-Bug
Now that the patch is reverted, I change the pr to 2 as we still need to work out a solution to enable impl border radius scrolling.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b7f637c29e9eae0b1b32b40b1056f7a93382a4

commit 58b7f637c29e9eae0b1b32b40b1056f7a93382a4
Author: sunxd <sunxd@chromium.org>
Date: Wed Jul 26 17:33:13 2017

Revert "cc: Enable composited border-radius scrolling."

This reverts commit 06adb5e74eb341b5a1fa68fed4e489f6f62ec5e8.

Reason for revert: Composited border-radius scrolling triggers two regression bugs: 1)  crbug.com/740720 , it results in high memory usage probably due to mask tiling not saving enough memory; 2)  crbug.com/745114 , compositor's scroll snapping can sometimes result in blurry text.

Original change's description:
> cc: Enable composited border-radius scrolling.
>
> Enable composited border-radius scrolling as mask tiling is implemented.
> We'll revert this CL if anything breaks.
>
> Bug:  567293 ,  567296 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I70bea4c542e00d244a597d1a36857dd120fc96cd
> Reviewed-on: https://chromium-review.googlesource.com/543397
> Commit-Queue: Xianda Sun <sunxd@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485040}

TBR=chrishtr@chromium.org, enne@chromium.org, flackr@chromium.org, schenney@chromium.org, sunxd@chromium.org, trchen@chromium.org


(cherry picked from commit 2397e783b2b5a59a174d25d26f66d467a8b0a88f)

Bug:  567293 ,  567296 ,  740720 ,  745114 
Change-Id: Ia185a9ce4310aeaff0175f0e9f0a9080dccf22e5
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/585227
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489477}
Reviewed-on: https://chromium-review.googlesource.com/586949
Cr-Commit-Position: refs/branch-heads/3163@{#61}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[add] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.html
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.txt
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius-expected.txt
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-border-radius-clipping-expected.png
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac/scrollbars/border-box-rect-clips-scrollbars-expected.png
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-border-radius-clipping-expected.png
[delete] https://crrev.com/87fcab7b0e641287d255d235222693de248f923b/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/58b7f637c29e9eae0b1b32b40b1056f7a93382a4/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

Cc: flackr@chromium.org chrishtr@chromium.org
 Issue 749611  has been merged into this issue.

Comment 8 by sunxd@chromium.org, Aug 3 2017

Cc: -trchen@chromium.org enne@chromium.org
This bug reproduces if we composite border radius, even if mask tiling is disabled. Hi enne@ and trchen@, can you provide some insights on this?

Also if I change the border to 1.5px, the text is rendered clearly.
Another report came in of this broken on 61.0.3163.79. Does not appear to repro on 62.0.3202.9.
Bisecting now.

Reading comment 8 now, I see that this bug was actually not fixed by the revert. And now it
made it into 61 stable. OTOH, comment 8 seems to indicate that the bug already exists in Chrome
60 and even earlier, since border-radius masking for non-stacking-context cases has been
launched for a while.
The bug was "fixed" by https://chromium.googlesource.com/chromium/src/+/f470dd6dfd2e88e40e344e5bd914c90c999ddbe4, which stops compositing input elements.

Does not fix the underlying issue with subpixel blurring and masks.
Labels: -Pri-2 M-63 Pri-1
Mergedinto: 762899
Status: Duplicate (was: Assigned)

Sign in to add a comment