New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745098 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Require cbuildbot api values for options.

Project Member Reported by dgarr...@chromium.org, Jul 18 2017

Issue description

We should make it hard to add a new option to cbuildbot without setting an 'api' version number for it. Multiple people have added new options without setting API versions, which then broke cbuildbot in backwards incompatible ways.

One approach:

  Make the 'api' option required, and set it for all existing values.


Example of an option that already has an API value:

  group.add_remote_option('--git-cache-dir', type='path',
                          api=constants.REEXEC_API_GIT_CACHE_DIR,
                          help='help text here')

 

Comment 1 by pho...@chromium.org, Jul 18 2017

Labels: -Type-Bug Type-Feature
Owner: dgarr...@chromium.org
Cc: xixuan@chromium.org
Status: Available (was: Untriaged)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Owner: ----
Status: Untriaged (was: Available)

Comment 7 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org

Sign in to add a comment