Syncing a Bookmark app tries to retrieve the app from the Chrome Web Store |
||
Issue descriptionFor regular apps we queue requests[1] to fetch the app from the store[2] (or wherever the app set as its update_url) and then install what we downloaded[3]. The only thing we actually sync for apps are settings[4][5]- the rest is downloaded. For bookmark apps, we can't actually fetch them from the store so we sync all the necessary data[6] and update the app manually[7]. Even after we manually update a Bookmark App[7] we don't return so we are trying to fetch bookmark apps from the store. There are no user-observable badness, just an unnecessary web store query. [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=522 [2] https://cs.chromium.org/chromium/src/extensions/browser/updater/extension_downloader.cc?q=extension+downloader&sq=package:chromium&dr=CSs&l=525 [3] https://cs.chromium.org/chromium/src/chrome/browser/extensions/updater/extension_updater.cc?gsn=CheckForUpdatesSoon&l=433 [4] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=57 [5] https://cs.chromium.org/chromium/src/components/sync/protocol/extension_specifics.proto?dr&l=20 [6] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=82 [7] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=511
,
Jul 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 18 2017