New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Syncing a Bookmark app tries to retrieve the app from the Chrome Web Store

Project Member Reported by ortuno@chromium.org, Jul 18 2017

Issue description

For regular apps we queue requests[1] to fetch the app from the store[2] (or
wherever the app set as its update_url) and then install what we downloaded[3]. The only thing
we actually sync for apps are settings[4][5]- the rest is downloaded.

For bookmark apps, we can't actually fetch them from the store so we sync all
the necessary data[6] and update the app manually[7].

Even after we manually update a Bookmark App[7] we don't return so we are trying
to fetch bookmark apps from the store.

There are no user-observable badness, just an unnecessary web store query.

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=522
[2] https://cs.chromium.org/chromium/src/extensions/browser/updater/extension_downloader.cc?q=extension+downloader&sq=package:chromium&dr=CSs&l=525
[3] https://cs.chromium.org/chromium/src/chrome/browser/extensions/updater/extension_updater.cc?gsn=CheckForUpdatesSoon&l=433
[4] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=57
[5] https://cs.chromium.org/chromium/src/components/sync/protocol/extension_specifics.proto?dr&l=20
[6] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=82
[7] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=511

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d775dfc51a3019722e0d131e30e7e83762ab5c

commit b7d775dfc51a3019722e0d131e30e7e83762ab5c
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Jul 18 03:20:16 2017

Stop trying to fetch bookmark apps from the store

For regular apps we queue requests[1] to fetch the app from the store[2] (or
wherever the app set as its update_url) and then install that[3]. The only thing
we actually sync for them are settings[4][5]- the rest is downloaded.

For bookmark apps, we can't actually fetch them from the store so we sync all
the necessary data[6] and update the app manually[7].

Even after we manually update a Bookmark App[7] we don't return so we are trying
to fetch bookmark apps from the store. This patch immediately returns after
updating the app.

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=522
[2] https://cs.chromium.org/chromium/src/extensions/browser/updater/extension_downloader.cc?q=extension+downloader&sq=package:chromium&dr=CSs&l=525
[3] https://cs.chromium.org/chromium/src/chrome/browser/extensions/updater/extension_updater.cc?gsn=CheckForUpdatesSoon&l=433
[4] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=57
[5] https://cs.chromium.org/chromium/src/components/sync/protocol/extension_specifics.proto?dr&l=20
[6] https://cs.chromium.org/chromium/src/components/sync/protocol/app_specifics.proto?dr&l=82
[7] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_sync_service.cc?type=cs&sq=package:chromium&l=511

Bug:  745097 
Change-Id: Ie5b60648738e5ad14076018999c2509bbe263979
Reviewed-on: https://chromium-review.googlesource.com/571520
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487371}
[modify] https://crrev.com/b7d775dfc51a3019722e0d131e30e7e83762ab5c/chrome/browser/extensions/extension_sync_service.cc

Comment 2 by ortuno@chromium.org, Jul 18 2017

Owner: ortuno@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment