Long tasks: replace settimeout with step_timeout in test |
||
Issue descriptionReplace settimeout with step_timeout in this test: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-parentiframe.html And update this lint exclusion: https://github.com/w3c/web-platform-tests/blob/e8cbae95a91b761a7b0194b3c0d560fd1947a29b/lint.whitelist#L164 testharness documentaion: http://web-platform-tests.org/writing-tests/testharness-api.html
,
Jul 20 2017
does it involve any functional change? or it's just a name change?
,
Jul 20 2017
I got it. It's functional change. I've found it in testharness.js API.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ae79f6845ea45bb6bc691dec8614ce85b302e1f commit 7ae79f6845ea45bb6bc691dec8614ce85b302e1f Author: Liquan (Max) Gu <maxlg@chromium.org> Date: Tue Aug 01 01:17:37 2017 Long tasks: replace settimeout with step_timeout in test and fix the test Replace settimeout with set_timeout in the test longtask-in-parentiframe.html, according to testharness-api. The original test fails because the long task is fired before the observer is created, so this CL fixes it by delaying the long task until the iframe is loaded. Bug: 745031 Change-Id: I89e0f0fab5ef0458c773f90ded428fc1a483913c Reviewed-on: https://chromium-review.googlesource.com/579593 Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Liquan Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#490831} [modify] https://crrev.com/7ae79f6845ea45bb6bc691dec8614ce85b302e1f/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist [modify] https://crrev.com/7ae79f6845ea45bb6bc691dec8614ce85b302e1f/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-parentiframe.html [modify] https://crrev.com/7ae79f6845ea45bb6bc691dec8614ce85b302e1f/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/subframe-observing-longtask.html
,
Aug 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by panicker@chromium.org
, Jul 17 2017