New issue
Advanced search Search tips

Issue 745005 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Explicitly remove ui/events/devices from DEPS for ash and chrome

Project Member Reported by sky@chromium.org, Jul 17 2017

Issue description

We shouldn't be using (most) of this code directly in mash. Getting this right and easily enforced may require moving some files. For example, enums are likely fine.
 
I could see making two targets, where things like DeviceDataManager/DeviceHotplugEventObserver/etc. should be not used in ash/chrome. The other half, InputDeviceManager/InputDevice/TouchscreenDevice/etc. is more client-y code though?

Comment 2 by sky@chromium.org, Jul 24 2017

Excellent idea!
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b840aa23c0d85adeadb283a6d41108015756d5f7

commit b840aa23c0d85adeadb283a6d41108015756d5f7
Author: James Cook <jamescook@chromium.org>
Date: Thu Oct 26 19:40:29 2017

cros: Fix ash_unittests --mus for TrayIME and VirtualKeyboardController

They were using ui::DeviceDataManager, which does not exist in mus.

Switch tests to use ui::InputDeviceManager and add test support methods.
I can't add an InputDeviceManagerTestApi because there are two different
concrete implementations.

Tighten DEPS restrictions for DeviceDataManager.

Bug: 745005,  747415 
Test: ash_unittests --mus
Change-Id: Ia3e250218888bda7f45d199575852979a568ad2c
Reviewed-on: https://chromium-review.googlesource.com/738850
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511926}
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/DEPS
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/display/DEPS
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ash/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/services/ui/public/cpp/input_devices/input_device_client.cc
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/services/ui/public/cpp/input_devices/input_device_client.h
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/testing/buildbot/filters/ash_unittests_mus.filter
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/device_data_manager.cc
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/device_data_manager.h
[modify] https://crrev.com/b840aa23c0d85adeadb283a6d41108015756d5f7/ui/events/devices/input_device_manager.h

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Sign in to add a comment