New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 742487



Sign in to add a comment

Create generic "Is this detected printer ready for use" mechanism

Project Member Reported by justincarlson@chromium.org, Jul 17 2017

Issue description

We need a way to determine whether a given printer has sufficient information to print without the user needing to give more.
 
Blocking: 742487
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97bf1addf6bc17dc8760d3678fe6f579312451d3

commit 97bf1addf6bc17dc8760d3678fe6f579312451d3
Author: Justin Carlson <justincarlson@chromium.org>
Date: Fri Jul 21 18:31:14 2017

Change PpdProvider API to make it discovery friendly.

This changes two main things.  First, and most significantly, the
way we resolve a PpdReference is unified -- instead of trying
a make-and-model string or trying usb ids, now we have a single
function to which you supply everything you know about the printer
and it gives you back a PpdReference or a failure.

Second, the way we support UI make, model listings changes.  When
the user asks for a list of supported printers from a manufacturer,
instead of getting back just the names, now the api returns the
names paired with the corresponding PpdReference.  Before, the
user had to call back into the ppd provider to get the reference, which
meant we had a weird "have to call this before that" sort of constraint
which this removes.

All callsites and tests updated as well.

Bug:  744996 
Change-Id: Ied385c087e4c3d6c1b21b924fcea772c786074c5
Reviewed-on: https://chromium-review.googlesource.com/580007
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488716}
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/97bf1addf6bc17dc8760d3678fe6f579312451d3/chromeos/printing/ppd_provider_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d9f08573ffcace0f52f3740bdf1dde28b11cccf

commit 4d9f08573ffcace0f52f3740bdf1dde28b11cccf
Author: Sean Kau <skau@chromium.org>
Date: Sat Jul 29 00:29:16 2017

Extend Printing detector interface to pass metadata.

This changes the PrinterDetector interface to pass through additional
metadata about printers in its API.  This will allow us to do automatic
driver searches in users of the Detection results.

Copy from https://chromium-review.googlesource.com/c/580587

Bug:  744996 ,  742487 ,  725739 
Change-Id: I8dc80224d35620c1614a6afb25e187f1ec00489b
Reviewed-on: https://chromium-review.googlesource.com/590586
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490556}
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/combining_printer_detector.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/combining_printer_detector_unittest.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/printer_detector.h
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee8297a091b698bb66275419070fe01d73d4457

commit dee8297a091b698bb66275419070fe01d73d4457
Author: xdai <xdai@chromium.org>
Date: Thu Aug 10 18:40:32 2017

[Merge to M61] Change PpdProvider API to make it discovery friendly.

This change needs to be merged to M61 in order to make
https://chromium-review.googlesource.com/c/592767 work in M61. Checked
with skau@ and justincarlson@, and it should be safe to do so.

This changes two main things.  First, and most significantly, the
way we resolve a PpdReference is unified -- instead of trying
a make-and-model string or trying usb ids, now we have a single
function to which you supply everything you know about the printer
and it gives you back a PpdReference or a failure.

Second, the way we support UI make, model listings changes.  When
the user asks for a list of supported printers from a manufacturer,
instead of getting back just the names, now the api returns the
names paired with the corresponding PpdReference.  Before, the
user had to call back into the ppd provider to get the reference, which
meant we had a weird "have to call this before that" sort of constraint
which this removes.

All callsites and tests updated as well.

TBR=justincarlson@chromium.org, skau@chromium.org, thestig@chromium.org
(cherry picked from commit 97bf1addf6bc17dc8760d3678fe6f579312451d3)

Bug:  744996 
Change-Id: Ied385c087e4c3d6c1b21b924fcea772c786074c5
Reviewed-on: https://chromium-review.googlesource.com/580007
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488716}
Reviewed-on: https://chromium-review.googlesource.com/610927
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#445}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/dee8297a091b698bb66275419070fe01d73d4457/chromeos/printing/ppd_provider_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6152c1f35f944f591fc282e1d27c74d503212a3f

commit 6152c1f35f944f591fc282e1d27c74d503212a3f
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:25:33 2017

Extend Printing detector interface to pass metadata.

This changes the PrinterDetector interface to pass through additional
metadata about printers in its API.  This will allow us to do automatic
driver searches in users of the Detection results.

Copy from https://chromium-review.googlesource.com/c/580587

TBR=skau@chromium.org

(cherry picked from commit 4d9f08573ffcace0f52f3740bdf1dde28b11cccf)

Bug:  744996 ,  742487 ,  725739 
Change-Id: I8dc80224d35620c1614a6afb25e187f1ec00489b
Reviewed-on: https://chromium-review.googlesource.com/590586
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490556}
Reviewed-on: https://chromium-review.googlesource.com/619770
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#658}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/combining_printer_detector.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/combining_printer_detector_unittest.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/printer_detector.h
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Status: Fixed (was: Assigned)
This has been fixed with the new CupsPrintersManager Automatic vs Discovered categories.

Sign in to add a comment