Add Event-prefix to Model and related classes |
||
Issue descriptionChrome Version: 2b4b718dfde955651c29edf12e08e3df694cd090 After the initial implementation, another model and store was added for availability. Therefore, classes related to events should be prefixed with Event, similarly to AvailabilityModel, etc. These are the required actions: A) The Model - Rename Model to EventModel - Rename ModelImpl to EventModelImpl - Rename InitAwareModel to InitAwareEventModel B) The Store - Rename Store to EventStore - Rename PersistentStore to PersistentEventStore - Rename InMemoryStore to InMemoryEventStore C) The StorageValidator - Rename StorageValidator to EventStorageValidator - Rename FeatureConfigStorageValidator to FeatureConfigEventStorageValidator - Rename NeverStorageValidator to NeverEventStorageValidator In addition, tests, etc. should be updated. The ConditionValidator checks both the Event- and Availability models, so it should not be renamed.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a2282243c3ad2ac00246dcbbab8ce63469daffe commit 1a2282243c3ad2ac00246dcbbab8ce63469daffe Author: Tommy Nyquist <nyquist@chromium.org> Date: Wed Jul 26 03:42:26 2017 Add Event-prefix to histogram enum for In-Product Help The Feature Engagement Tracker histograms were not updated at the same time as the rest of the code was updated to use an Event-prefix for all class names and members in: https://chromium-review.googlesource.com/580707 This adds the same convention to the enum values used for UMA histograms, and updates both the C++ enum, and the UMA label. Since this is only a descriptive label, and the integer value does not change, it is safe to edit the current value instead of adding a new one. BUG= 744953 Change-Id: Ib7f547406041c2fe8ebdaf945de443d8b5a0138c Reviewed-on: https://chromium-review.googlesource.com/585233 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#489544} [modify] https://crrev.com/1a2282243c3ad2ac00246dcbbab8ce63469daffe/components/feature_engagement_tracker/internal/stats.cc [modify] https://crrev.com/1a2282243c3ad2ac00246dcbbab8ce63469daffe/components/feature_engagement_tracker/internal/stats.h [modify] https://crrev.com/1a2282243c3ad2ac00246dcbbab8ce63469daffe/tools/metrics/histograms/enums.xml
,
Jul 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 25 2017