New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

InsertOrderedList command applied to table cells inserts an extra BR before the table

Project Member Reported by jfernan...@igalia.com, Jul 17 2017

Issue description

Chrome Version:  61.0.3135.4

What steps will reproduce the problem?
(1) Load the attached test case. The contents of the table will be selected on load
(2) Hit the "List" button multiple times. 

What is the expected result?

The cell content become a list item after the first click. List items become regular text after a new click. Subsequent clicks will produce the same results.

What happens instead?

On every second click, the table will move down.


 
noBRAtStartOfPara.html
376 bytes View Download
Owner: jfernan...@igalia.com
Status: Started (was: Untriaged)

Comment 2 by yosin@chromium.org, Aug 1 2017

Online version of sample: https://jsfiddle.net/3zncgu24/
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e5ec55dd115f8663389231c82928066184def96

commit 1e5ec55dd115f8663389231c82928066184def96
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Thu Aug 10 20:21:49 2017

Don't add BR when pruning empty blocks if it's the start of a paragraph

The function MoveParagraph is used for several operations and editing
commands, like 'insertOrderedList'. When moving paragraphs we check out
whether we should add a 'br' element to avoid undesired block collapse.

However, we shouldn't do this when destination is the start of a
paragraph.

Bug:  744936 
Change-Id: I366b903b5f3737bd6c84e9fc8c91a4894ca680af
Reviewed-on: https://chromium-review.googlesource.com/581008
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493504}
[add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-items-in-table-cell.html
[add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/external/wpt/editing/data/insert-list-items-in-table-cells.js
[add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/external/wpt/editing/run/insert-list-items-in-table-cell.html
[modify] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Status: Fixed (was: Started)
This issue should be FIXED now.

Sign in to add a comment