InsertOrderedList command applied to table cells inserts an extra BR before the table |
||
Issue descriptionChrome Version: 61.0.3135.4 What steps will reproduce the problem? (1) Load the attached test case. The contents of the table will be selected on load (2) Hit the "List" button multiple times. What is the expected result? The cell content become a list item after the first click. List items become regular text after a new click. Subsequent clicks will produce the same results. What happens instead? On every second click, the table will move down.
,
Aug 1 2017
Online version of sample: https://jsfiddle.net/3zncgu24/
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e5ec55dd115f8663389231c82928066184def96 commit 1e5ec55dd115f8663389231c82928066184def96 Author: Javier Fernandez <jfernandez@igalia.com> Date: Thu Aug 10 20:21:49 2017 Don't add BR when pruning empty blocks if it's the start of a paragraph The function MoveParagraph is used for several operations and editing commands, like 'insertOrderedList'. When moving paragraphs we check out whether we should add a 'br' element to avoid undesired block collapse. However, we shouldn't do this when destination is the start of a paragraph. Bug: 744936 Change-Id: I366b903b5f3737bd6c84e9fc8c91a4894ca680af Reviewed-on: https://chromium-review.googlesource.com/581008 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#493504} [add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-items-in-table-cell.html [add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/external/wpt/editing/data/insert-list-items-in-table-cells.js [add] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/LayoutTests/external/wpt/editing/run/insert-list-items-in-table-cell.html [modify] https://crrev.com/1e5ec55dd115f8663389231c82928066184def96/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
,
Aug 10 2017
This issue should be FIXED now. |
||
►
Sign in to add a comment |
||
Comment 1 by jfernan...@igalia.com
, Jul 21 2017Status: Started (was: Untriaged)