Evaluate if ui::ws::EventDispatcher::SetMousePointerDisplayLocation() needs to process mouse |
|||
Issue descriptionCurrently SetMousePointerDisplayLocation() updates the cursor location, but it doesn't process the call in the same way as if a MouseEvent were generated (clients and internal state aren't updated). This means clients won't get a MouseEvent and some internal processing may not happen. I'm not sure what the expectation of this function is.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d0ea383e300bdbd091e262c573f4de49cb3c603 commit 5d0ea383e300bdbd091e262c573f4de49cb3c603 Author: Elliot Glaysher <erg@chromium.org> Date: Thu Aug 10 22:49:26 2017 Have SetMousePointerDisplayLocation() build synthetic events. Previously, we just changed the location of the mouse pointer when we set the mouse pointer display location. This meant that internal caches weren't being updated, and windows weren't receiving mouse move/exit events when this happened. This patch changes direct setting to building a synthetic mouse move event and putting it through normal event dispatch. EventDispatcherTest.SetMousePointerDisplayLocationWith(out)Flags Bug: 744923 Change-Id: Ib8625db3dd1955c9ec41512176e71333dbfcf6fb Test: WindowTreeTest.TestWindowManagerSettingCursorLocation, Reviewed-on: https://chromium-review.googlesource.com/609305 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#493577} [modify] https://crrev.com/5d0ea383e300bdbd091e262c573f4de49cb3c603/services/ui/ws/event_dispatcher.cc [modify] https://crrev.com/5d0ea383e300bdbd091e262c573f4de49cb3c603/services/ui/ws/event_dispatcher.h [modify] https://crrev.com/5d0ea383e300bdbd091e262c573f4de49cb3c603/services/ui/ws/event_dispatcher_unittest.cc
,
Aug 10 2017
Hmm. Gerrit really mangled those multiline Test: lines...
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 18 2017