investigate why ICU initialization is not correct for webview unittests |
||
Issue descriptionWhen I tried to add a unittest for WebView that includes using punycode (i.e. testing for "☃.net/" it did crash in icu with message: 07-17 20:24:42.846 30982 30982 E chromium: [ERROR:icu_util.cc(174)] Invalid file descriptor to ICU data received. 07-17 20:24:42.872 30982 30982 F chromium: [FATAL:url_canon_icu.cc(104)] Check failed: false. failed to open UTS46 data with error: 4 it seems that we are still calling ICU initialization though: base::test::InitializeICUForTesting(); so the bug is probably a lot deeper.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdfaad53f18258f733a738c97e2dd7c89ec45e58 commit cdfaad53f18258f733a738c97e2dd7c89ec45e58 Author: Selim Gurun <sgurun@google.com> Date: Tue Sep 05 22:56:01 2017 Fix ICU initialization and add a test for punycode When we added whitelist manager, we could not add a unit test for punycode because ICU was failing. This fixes the ICU fail (the icu data file was not loaded) and adds a test. BUG= 744896 Change-Id: Ic1d7b830421f2c47df3427237a243558cde1fb3c Reviewed-on: https://chromium-review.googlesource.com/648336 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#499779} [modify] https://crrev.com/cdfaad53f18258f733a738c97e2dd7c89ec45e58/android_webview/browser/aw_safe_browsing_whitelist_manager_unittest.cc [modify] https://crrev.com/cdfaad53f18258f733a738c97e2dd7c89ec45e58/android_webview/test/BUILD.gn
,
Sep 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sgu...@chromium.org
, Jul 17 2017