Investigate file locking for LevelDB on Fuchsia |
|||||
Issue descriptionCurrently Fuchsia doesn't implement flock() syscall. It's used in Chrome to provide locking for LevelDB. Normally profile directories can be accessed only from a single process, so in-process locking should be sufficient. Need investigate if there is a case when cross-process locks are useful. If yes, then implement some cross-process locking mechanism.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ddf7b921d7a48664789e791ad2fc132a798831 commit 89ddf7b921d7a48664789e791ad2fc132a798831 Author: Sergey Ulanov <sergeyu@google.com> Date: Tue Jul 18 02:15:24 2017 Disable OS file locking on Fuchsia Fuchsia doesn't support file locking, i.e. there is no base::File::Lock(), so components/filesystem was failing to compile. Added ifdefs so File::Lock() is not used on Fuchsia. Bug: 737802 , 744893 Change-Id: I825fba49b9c6247d1b4c75ca23fce4c150344db1 Reviewed-on: https://chromium-review.googlesource.com/575288 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487347} [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/file_impl.cc [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/file_impl.h [modify] https://crrev.com/89ddf7b921d7a48664789e791ad2fc132a798831/components/filesystem/lock_table.cc
,
Jul 19 2017
,
Jul 20
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Jan 15
data directories are not supposed to be shared between multiple context processes, so I don't think we need a file locking |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sergeyu@chromium.org
, Jul 17 2017