New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 744815 link

Starred by 1 user
Status: Fixed
Owner:
eroman@chromium.org
Closed: Jul 2017
Cc:
█ xunji...@chromium.org
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

net/log/stitch_net_log_files.py does not order events from oldest to newest

Project Member Reported by eroman@chromium.org, Jul 17 2017 
net/log/stitch_net_log_files.py concatenates the events files starting from event_file_0.json and progressing until event_file_<num_files-1>.json.

However because use of file indices wraps around, event_file_0.json is not be the oldest file.

Also, this file should be moved into net/tools/
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83caa18452f7dfd2bc938ac639f43fcae14ad55d

commit 83caa18452f7dfd2bc938ac639f43fcae14ad55d
Author: Eric Roman <eroman@chromium.org>
Date: Tue Jul 18 23:08:31 2017

Move stitch_net_log_files.py into net/tools/

Bug:  744815 
Change-Id: Ia7e7d9ef3343f5489d03e0d3ad29f63f9473f146
Reviewed-on: https://chromium-review.googlesource.com/576608
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487650}
[modify] https://crrev.com/83caa18452f7dfd2bc938ac639f43fcae14ad55d/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
[rename] https://crrev.com/83caa18452f7dfd2bc938ac639f43fcae14ad55d/net/tools/stitch_net_log_files.py

Comment 2 by eroman@chromium.org, Jul 19 2017

Owner: eroman@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0cce18076a81ed7714f84f2e4dc03613811b92

commit 4d0cce18076a81ed7714f84f2e4dc03613811b92
Author: Eric Roman <eroman@chromium.org>
Date: Wed Jul 19 23:46:53 2017

Make stitch_net_log_files.py handle more cases.

 * Order event files from oldest to newest
 * Remove the --num_files switch
 * Don't fail if end_netlog.json is missing (since it probably will be
   when using this)

Bug:  744815 
Change-Id: I26307d3c293eb445b7e3456d6b359f8ef05a0204
Reviewed-on: https://chromium-review.googlesource.com/578484
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488045}
[modify] https://crrev.com/4d0cce18076a81ed7714f84f2e4dc03613811b92/net/tools/stitch_net_log_files.py

Comment 4 by eroman@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment