New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744797 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[DevTools] disable test before V8 roll

Project Member Reported by kozyatinskiy@chromium.org, Jul 17 2017

Issue description

One of the future V8 roll will remove one more useless source position [1].

[1] https://chromium-review.googlesource.com/c/543161/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9486c251dc244a3bf3873d5803fb7ac2799383dc

commit 9486c251dc244a3bf3873d5803fb7ac2799383dc
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jul 17 21:21:45 2017

[DevTools] disable test for V8 roll

This test will be fixed with one of the following V8 roll:
inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html

TBR=dgozman@chromium.org

Bug:  chromium:744797 
Change-Id: I42fdf32261d98c6723384565263693dc9948b80c
Reviewed-on: https://chromium-review.googlesource.com/575089
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487247}
[modify] https://crrev.com/9486c251dc244a3bf3873d5803fb7ac2799383dc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9486c251dc244a3bf3873d5803fb7ac2799383dc/third_party/WebKit/LayoutTests/inspector/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b282477655a78d97a5e25f89c4612e3dfa61115a

commit b282477655a78d97a5e25f89c4612e3dfa61115a
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jul 21 23:44:27 2017

[DevTools] reenable test

V8 change was rolled to Chromium.

TBR=dgozman@chromium.org

Bug:  744797 
Change-Id: I5a22edb0c1cc76a4f13bf6b9a9ac576e3df38065
Reviewed-on: https://chromium-review.googlesource.com/582082
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488805}
[modify] https://crrev.com/b282477655a78d97a5e25f89c4612e3dfa61115a/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment