New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 744778 link

Starred by 2 users
Status: Archived
Owner:
newcomer@chromium.org
Closed: Aug 2017
Cc:
█ maajid@chromium.org
█ vadimt@chromium.org
weidongg@chromium.org
█ warx@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Unhandled events not propogating from StartPageView to AppListView

Project Member Reported by newcomer@chromium.org, Jul 17 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Open Peeking Launcher
(2) Click between the apps.
(3)

What is the expected result?
Launcher should close

What happens instead?
Unhandled click events are not propogating up to the AppListView. Check StartPageView

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by newcomer@chromium.org, Jul 27 2017

Labels: Merge-Request-61
Status: Started (was: Available)
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 1 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/236d3a7e7eb6a4c0815b727b9c30bee059330e76

commit 236d3a7e7eb6a4c0815b727b9c30bee059330e76
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Aug 01 18:54:11 2017

cros: Launcher: Fixed OnMousePressed

OnMousePressed now properly returns true if the event is consumed. This
fixes the bug where unhandled mouse events were not propogating to the
AppListView.

Bug:  744778 
Change-Id: I46cf1eb64994221b37ef186754d5409c5ddbd466
Reviewed-on: https://chromium-review.googlesource.com/589819
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491064}
[modify] https://crrev.com/236d3a7e7eb6a4c0815b727b9c30bee059330e76/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/236d3a7e7eb6a4c0815b727b9c30bee059330e76/ui/app_list/views/start_page_view.cc

Comment 5 by newcomer@chromium.org, Aug 1 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 4 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 4 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a348d4fd1f62630a262b6412f6d5f9716f23041

commit 9a348d4fd1f62630a262b6412f6d5f9716f23041
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Aug 04 17:46:26 2017

cros: Launcher: Fixed OnMousePressed

OnMousePressed now properly returns true if the event is consumed. This
fixes the bug where unhandled mouse events were not propogating to the
AppListView.

TBR=newcomer@chromium.org

(cherry picked from commit 236d3a7e7eb6a4c0815b727b9c30bee059330e76)

Bug:  744778 
Change-Id: I46cf1eb64994221b37ef186754d5409c5ddbd466
Reviewed-on: https://chromium-review.googlesource.com/589819
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491064}
Reviewed-on: https://chromium-review.googlesource.com/602372
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#318}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9a348d4fd1f62630a262b6412f6d5f9716f23041/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/9a348d4fd1f62630a262b6412f6d5f9716f23041/ui/app_list/views/start_page_view.cc

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment