MidiTaskServiceTest.RunBoundTasks failing on v1 chromecast device |
||
Issue description
build/run midi unittests on v1 chromecast:
[ RUN ] MidiTaskServiceTest.RunBoundTasks
../../media/midi/task_service_unittest.cc:220: Failure
Expected: 1u
Which is: 1
To be equal to: client->count()
Which is: 0
[ FAILED ] MidiTaskServiceTest.RunBoundTasks (2 ms)
Note: Cast is not yet sync'd up to pick up https://chromium-review.googlesource.com/c/544371/ yet, so it's possible that may fix the issue. I will test that locally; if it fixes it then I can CP it, otherwise I will disable the test for now to re-green our dashboards for further investigation
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3c08c1c0b5f8ef765345e70d8609975abf3d156 commit f3c08c1c0b5f8ef765345e70d8609975abf3d156 Author: Mike Bjorge <mbjorge@chromium.org> Date: Tue Jul 18 20:14:12 2017 [Chromecast] Temporarily disable MidiTaskServiceTest.RunBoundTasks This test is failing on v1 devices. Disable the test temporarily to get the dashboards green again so this failure doesn't mask other failures. Should get re-enabled once the test issue is resolved. BUG= 744777 TEST=midi_unittests Change-Id: I4db7b1fdb7ce9b73f8e9cf161b4080cf9e10f143 Reviewed-on: https://chromium-review.googlesource.com/575197 Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#487578} [modify] https://crrev.com/f3c08c1c0b5f8ef765345e70d8609975abf3d156/chromecast/BUILD.gn
,
Jul 19 2017
Oops, I found a bug in the test. I will fix it soon. So, can you re-enable it once I submit the fix?
,
Jul 19 2017
I sent a review request to you; https://chromium-review.googlesource.com/c/575325/ Thanks!
,
Jul 19 2017
Thanks for the fix, I will re-enable once it lands
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0448d701fdcbdece897c5a12552e040969dc7fa commit f0448d701fdcbdece897c5a12552e040969dc7fa Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Thu Jul 20 12:19:20 2017 Web MIDI: IncrementCount() should be called before signaling MidiTaskServiceTest.RunBoundTasks failing on v1 chromecast device. This is because the test increments the count after signaling the event, and it results in racy results because expectation check could run before the count is incremented. This patch fixes this problem and is expected to solve the problem that RunBoundTasks failing on v1 chromecast device. Bug: 744777 Change-Id: Id318353795025adbf204be90d381fa6b696d2390 Reviewed-on: https://chromium-review.googlesource.com/575325 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#488209} [modify] https://crrev.com/f0448d701fdcbdece897c5a12552e040969dc7fa/media/midi/task_service_unittest.cc
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7a4f77d7ee24ed00157a0e516060b3a87edae56 commit f7a4f77d7ee24ed00157a0e516060b3a87edae56 Author: Mike Bjorge <mbjorge@chromium.org> Date: Fri Jul 28 04:08:53 2017 Revert "[Chromecast] Temporarily disable MidiTaskServiceTest.RunBoundTasks" This reverts commit f3c08c1c0b5f8ef765345e70d8609975abf3d156. Reason for revert: Race condition in test code has been fixed in https://chromium-review.googlesource.com/575325 Original change's description: > [Chromecast] Temporarily disable MidiTaskServiceTest.RunBoundTasks > > This test is failing on v1 devices. Disable the test temporarily to > get the dashboards green again so this failure doesn't mask other > failures. Should get re-enabled once the test issue is resolved. > > BUG= 744777 > TEST=midi_unittests > > Change-Id: I4db7b1fdb7ce9b73f8e9cf161b4080cf9e10f143 > Reviewed-on: https://chromium-review.googlesource.com/575197 > Reviewed-by: Stephen Lanham <slan@chromium.org> > Commit-Queue: Mike Bjorge <mbjorge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487578} TBR=slan@chromium.org,mbjorge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 744777 Change-Id: I182f1b90d47d33a35ae530a20d005664c5527492 Reviewed-on: https://chromium-review.googlesource.com/580027 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#490257} [modify] https://crrev.com/f7a4f77d7ee24ed00157a0e516060b3a87edae56/chromecast/BUILD.gn
,
May 21 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mbjorge@chromium.org
, Jul 17 2017