New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 744771 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue skia:6858
Blocking:
issue 634542



Sign in to add a comment

Use makeSubset in color managed createImageBitmap code

Project Member Reported by zakerinasab@chromium.org, Jul 17 2017 
In CanvasRenderingContext2DTest.ImageBitmapColorSpaceConversion() unit test, the crop rect is set to (300,150) to avoid calling SkImage::makeSubset() from CropImageAndApplyColorSpaceConversion() in ImagBitmap.cpp. This is due to bugs.chromium.org/p/skia/issues/detail?id=6858. When this bug is fixed, change the size of crop rect to (10,10) or something similar to test the correct behavior of makeSubset() and make the unit test run faster.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7fd22f317beac6690f337a105dc0623ea720818

commit d7fd22f317beac6690f337a105dc0623ea720818
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Fri Aug 25 21:49:13 2017

Update CRC2DTest.ImageBitmapColorSpaceConversion to use SkImage::makeSubset

SkImage::makeSubset was not preserving the color space of the source image
(skia:6858). Now that this bug is fixed, the crop rect in
CRC2DTest.ImageBitmapColorSpaceConversion can change to test crop rect in
ImageBitmap.

Bug:  744771 
Change-Id: I130c516e2212d643c77ddca56cd3e1d88291ad9e
Reviewed-on: https://chromium-review.googlesource.com/634243
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497551}
[modify] https://crrev.com/d7fd22f317beac6690f337a105dc0623ea720818/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Comment 2 by zakerinasab@chromium.org, Aug 26 2017

Status: Fixed (was: Assigned)

Comment 3 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment