Make grouping generate a more human-readable title for a group |
||||
Issue descriptionIt would be nicer for users if the alert group names were set to something based on the alerts by default. It's unclear what the names should be though. Including data from the alerts might be a bit tricky since the alerts that were used to generate the title could be ungrouped, causing the titles to become obsolete. So, maybe it might make sense to make generated semantic titles more of a frontend concept? ie: if a custom title has not been created, an alert group is called something like "veyron_jaq-nyc-android-pfq:470 failed and 5 other failures", and this is recomputed in the frontend whenever the user changes the group. Then, if a user overrides this default title, from that point onwards the group will be referred to by the custom title.
,
Jul 17 2017
So "key + N other failures"? How do we pick the initial key?
,
Jul 17 2017
I'm not sure what would be the best approach for this. Perhaps we could pick whichever alert would normally be highest in the alert sort order (mostly severity but in the future, we could add sorting based on things like number of text failures)? Also completely open to other suggestions for other formats for readable alert titles.
,
Jul 17 2017
I can't think of much better off the top of my head. It should be fairly simple to do: after computing the alerts, do a sort on the sub-alert list of each group and generate a name from that. Probably not worth implementing until my current change lands since it will most certainly conflict.
,
Jul 21 2017
,
Jul 21 2017
Can you just not show a name by default? Show an input box with placeholder text "Custom group name (optional)" or something like that.
,
Jul 21 2017
Not having any sort of autogenerated name would be fine and probably easier to implement. If that's preferable to attempting to prefill the name somehow, I'm for it.
,
Jul 21 2017
I'd prefer to prefill a name. I'd rather have something distinguishing groups, rather than a total blank slate. I think we need to make the editing of a group name more discoverable too, but not sure how.
,
Jul 21 2017
One though: it'd be useful to allow users to set a name for a group when they first group alerts together. Perhaps autogenerated names could primarily exist as suggestions when the user is prompted to name their new group? I think if users enter a name when they first create a group, it'd be more clear that the title of the group represents the name, so the renaming UI could probably be kept largely the same. We'd probably still want to tweak it some so users realize it is an edit form. I think this could be done with some lightweight changes. For example, we could add a lightweight edit button to the right of the input field which focuses the input when clicked. Then when the input is focused/while the content has been changed, the edit button could convert into "Save"/"Cancel" buttons.
,
Jul 21 2017
Perhaps "Group" can have an editable group-name at the top, and "Group All" without an existing group can pop up a "name this group" dialog box?
,
Dec 14 2017
,
Feb 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zhangtiff@chromium.org
, Jul 17 2017