New issue
Advanced search Search tips

Issue 744740 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.1% regression in blink_perf.parser at 486666:486715

Project Member Reported by nzolghadr@chromium.org, Jul 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=744740

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e42afd6e6e63f2516397195df65eaa104e684c4cc62c68d72effee9cabf62bf8


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 17 2017

Cc: sunn...@chromium.org
Owner: sunn...@chromium.org

=== Auto-CCing suspected CL author sunnyps@chromium.org ===

Hi sunnyps@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Sunny Sachanandani
  Commit : 057d5553e4524a7726b2e7d5ecfef85289379000
  Date   : Fri Jul 14 04:07:29 2017
  Subject: cc: Dump more state in begin main frame hang crash key.

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.parser
  Metric       : innerHTML-setter/innerHTML-setter
  Change       : 9.96% | 821.229104521 -> 739.396552115

Revision             Result                  N
chromium@486665      821.229 +- 35.0488      6      good
chromium@486669      783.561 +- 19.3567      6      good
chromium@486670      726.967 +- 26.0218      6      bad       <--
chromium@486671      723.231 +- 37.965       6      bad
chromium@486672      726.114 +- 32.7621      6      bad
chromium@486678      727.167 +- 38.9057      6      bad
chromium@486690      739.087 +- 19.6461      6      bad
chromium@486715      739.397 +- 18.1917      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973798432285416336


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 18 2017

 Issue 744732  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 19 2017

 Issue 744741  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jul 19 2017

Cc: toyoshim@chromium.org
 Issue 746246  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1efdc3eec28f62fab81f4d9f6c224302675a7d5

commit a1efdc3eec28f62fab81f4d9f6c224302675a7d5
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Thu Jul 20 00:18:59 2017

cc: Remove crash logging for BeginMainFrame hang.

This regressed some benchmarks and also accounts for a few percent of
power consumption.

Revert "cc: Add crash key for debugging BeginMainFrame renderer hang."

This reverts commit 7a4f2242badc95b109bb551e2ec1ebcebc2ff0d2.

Revert "cc: Dump more state in begin main frame hang crash key."

This reverts commit 057d5553e4524a7726b2e7d5ecfef85289379000.

TBR=brianderson,rsesek,alokp,scottmg,brucedawson
BUG=622080, 744740 , 742471 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib96e7ca083c4ce3a22890b8d6e822f57dd391ef7
Reviewed-on: https://chromium-review.googlesource.com/578066
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488060}
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler.cc
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler.h
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler_state_machine.cc
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/cc/scheduler/scheduler_state_machine.h
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/common/crash_keys.cc
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chrome/common/crash_keys.h
[modify] https://crrev.com/a1efdc3eec28f62fab81f4d9f6c224302675a7d5/chromecast/crash/cast_crash_keys.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment