separate transparent background from alpha channel |
||
Issue descriptionCVV uses transparent background mode for better transitions, and requires an alpha channel from the compositor. CompositorImpl::SetHasTransparentBackground handles both. CompositorImpl should support SetRequiresAlphaChannel, so that AndroidOverlay can use that separetely from setting the background.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7 commit cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7 Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Jul 18 15:39:38 2017 Separate HasTransparentBackground from RequiresAlphaChannel. ContentVideoView uses both an alpha channel and a transparent background at the same time. AndroidOverlay will need only the former. Currently, they're set together in CompositorImpl. This CL separates them with SetRequiresAlphaChannel, and updates CVV callers to call both. Bug: 744706 Change-Id: I7c9e5d258e68fa35c7a5f8a611d942dc9c460389 Reviewed-on: https://chromium-review.googlesource.com/574640 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#487484} [modify] https://crrev.com/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7/chrome/browser/android/compositor/compositor_view.cc [modify] https://crrev.com/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7/content/browser/android/content_view_render_view.cc [modify] https://crrev.com/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7/content/browser/renderer_host/compositor_impl_android.h [modify] https://crrev.com/cebd3b079bbbe1716c0c4b5dc0ae27c03f5876a7/content/public/browser/android/compositor.h
,
Oct 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by liber...@chromium.org
, Jul 17 2017