Clean up perf fyi waterfall |
|||||||||||
Issue descriptionWe should clean up perf fyi waterfall. This would include: 1) Remove all the builders & testers that are not using swarming 2) Remove ones that are no longer needed.
,
Jul 26 2017
,
Oct 2 2017
,
Oct 3 2017
,
Oct 3 2017
So I can find it easily, link to builders on this waterfall: https://build.chromium.org/p/chromium.perf.fyi/builders
,
Oct 3 2017
Stephen can you link the bug for our new FYI bot for one buildbot step in the labs to this one? we don't want to accidentally have it taken down before we get it operationa l :) Feel free to re-assign to me after that is done.
,
Oct 4 2017
Ned, Annie, could either of you confirm before I hit the red button. These are the bots I'm going to remove (they still use run_sharded_perf_tests, i.e. they are not swarmed): - Android Power Nexus 5X Perf - Win 7 Intel GPU Perf (Xeon) - Win Power High-DPI Perf - Mac Power Dual-GPU Perf - Mac Power Low-End Perf - Mac Test Retina Perf - Win Clang Perf - Win Clang Perf Ref Remove bots: https://chromium-review.googlesource.com/c/chromium/tools/build/+/698324 Remove recipes: https://chromium-review.googlesource.com/c/chromium/tools/build/+/698404 Is this OK? Also martiniss asked on one of the CLs: "Do we want to keep these platforms? Or just give up on those builders."
,
Oct 4 2017
That list SGTM. I also think we can remove further FYI bots but that can be done separately.
,
Oct 4 2017
All right. Started removing the bots. So we don't lose track of them, these are the hostnames being released: - build110-b1 - build169-m1 - build85-b1 - build88-m1 - build35-b1 - build36-b1 - build83-b1 martiniss also suggested filing a labs ticket with go/infrasys-bug to get those reclaimed. Waiting for answer on what to do with them: keep them? give them up?
,
Oct 4 2017
I think we should give them up to the lab.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8c16b175d843793ce229563f6a8e65129bfc558c commit 8c16b175d843793ce229563f6a8e65129bfc558c Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Wed Oct 04 13:53:19 2017 Remove non-swarmed bots from chromium.perf.fyi Remove the following bots from chromium.perf.fyi: - Android Power Nexus 5X Perf - Win 7 Intel GPU Perf (Xeon) - Win Power High-DPI Perf - Mac Power Dual-GPU Perf - Mac Power Low-End Perf - Mac Test Retina Perf - Win Clang Perf - Win Clang Perf Ref Bug:744679 Change-Id: I4a38b4788deb0c69792f1a27d74ee5b8e97edf3d Reviewed-on: https://chromium-review.googlesource.com/698324 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/8c16b175d843793ce229563f6a8e65129bfc558c/masters/master.chromium.perf.fyi/master.cfg [modify] https://crrev.com/8c16b175d843793ce229563f6a8e65129bfc558c/masters/master.chromium.perf.fyi/slaves.cfg
,
Oct 4 2017
,
Oct 4 2017
Filed issue 771628 to give up the hosts.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/95e5cdba98dd720546d5fb45f683933a4de1a393 commit 95e5cdba98dd720546d5fb45f683933a4de1a393 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Wed Oct 04 15:33:29 2017 Remove non-swarmed chrompium_perf_fyi recipes This is the counterpart to https://chromium-review.googlesource.com/c/chromium/tools/build/+/698324 Removing the recipes of those bots. This also removes one of the deprecated clients of run_sharded_perf_tests. Bug:744679 Change-Id: I19b0cfbe09f5cc9b9efe0c6b0c825c59143919f0 Reviewed-on: https://chromium-review.googlesource.com/698404 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipe_modules/chromium_tests/steps.py [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipe_modules/chromium_tests/tests/steps/json_results_handler.expected/invalid.json [modify] https://crrev.com/95e5cdba98dd720546d5fb45f683933a4de1a393/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/cross_master_trigger.json
,
Oct 16 2017
Old non-swarmed bots from: https://build.chromium.org/p/chromium.perf.fyi/builders are now gone! :)
,
Oct 18 2017
,
Jan 8 2018
I believe this is fixed?
,
Jan 9 2018
I did all of (1) from the original bug description. Not sure if there was anything else to do for (2)?
,
Jan 9 2018
For your part Juan yes this is fixed. We still have two low end machines (Win 10 Low-End Perf Tests and Win 10 4 Core Low-End Perf tests) that are no longer in use. I will re-open and assign to myself for that since it isn't a part of the perf waterfall refactor that we are working on for 2018. These are just stale.
,
Feb 1 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3e491ea104577d9205027b7bd2ec5d1c149aaac0 commit 3e491ea104577d9205027b7bd2ec5d1c149aaac0 Author: Emily Hanley <eyaich@google.com> Date: Sat Feb 03 00:54:40 2018 Removing deprecated low end laptops from pref waterfall. Bug:744679 Change-Id: I0defcd2407bff0daa1868849ed9d57c0d5426c38 Reviewed-on: https://chromium-review.googlesource.com/896400 Reviewed-by: David Tu <dtu@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> [modify] https://crrev.com/3e491ea104577d9205027b7bd2ec5d1c149aaac0/masters/master.chromium.perf.fyi/master.cfg [modify] https://crrev.com/3e491ea104577d9205027b7bd2ec5d1c149aaac0/masters/master.chromium.perf.fyi/slaves.cfg
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72ab0795ebdd87dc52741f82cb30d0a9adadfcd2 commit 72ab0795ebdd87dc52741f82cb30d0a9adadfcd2 Author: Emily Hanley <eyaich@google.com> Date: Sat Feb 03 03:04:47 2018 Removing deprecated low end laptops from perf fyi waterfall. Bug: 744679 Change-Id: Idc3ca11a2a3cf80e18f8da45c6943232672d8890 Reviewed-on: https://chromium-review.googlesource.com/897347 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#534251} [modify] https://crrev.com/72ab0795ebdd87dc52741f82cb30d0a9adadfcd2/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/72ab0795ebdd87dc52741f82cb30d0a9adadfcd2/tools/perf/core/benchmark_sharding_map.json [modify] https://crrev.com/72ab0795ebdd87dc52741f82cb30d0a9adadfcd2/tools/perf/core/perf_data_generator.py
,
Feb 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/223de5e00ba0ef4857b9697caf5446911213defd commit 223de5e00ba0ef4857b9697caf5446911213defd Author: Emily Hanley <eyaich@google.com> Date: Wed Feb 07 18:33:14 2018
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3b3655708089426068817b43b6dd190a575d60cc commit 3b3655708089426068817b43b6dd190a575d60cc Author: Emily Hanley <eyaich@google.com> Date: Fri Feb 09 13:46:03 2018 Finish removing the low end laptops from the master configs Bug:744679 Change-Id: Ib2265dafdb45b6bd4208136e34a19ccbca24d6a4 Reviewed-on: https://chromium-review.googlesource.com/900165 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: David Tu <dtu@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_histograms.json [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_task_failure.json [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.py [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_failed_upload.json [modify] https://crrev.com/3b3655708089426068817b43b6dd190a575d60cc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fbd8362b3c478511bb96f38a54864b92cacfb53 commit 4fbd8362b3c478511bb96f38a54864b92cacfb53 Author: Nghia Nguyen <nednguyen@google.com> Date: Tue Feb 13 22:21:03 2018 Remove obsolete perf builders from Milo Bug:744679, 811947 Change-Id: I8cb96c502cc1db48989834eab4dabfc22d23681c Reviewed-on: https://chromium-review.googlesource.com/917183 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/4fbd8362b3c478511bb96f38a54864b92cacfb53/luci-milo-dev.cfg [modify] https://crrev.com/4fbd8362b3c478511bb96f38a54864b92cacfb53/luci-milo.cfg
,
Jan 7
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 18 2017