New issue
Advanced search Search tips

Issue 744675 link

Starred by 2 users
Status: Fixed
Owner:
billorr@chromium.org
Closed: Nov 2017
Cc:
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Task
Proj-XR

Blocking:
issue 773882



Sign in to add a comment

Make CQ run vr_common_unittests on Windows

Project Member Reported by cjgrant@chromium.org, Jul 17 2017 
The common VR code, and associated unit tests, are platform-agnostic.  Currently, the code is only used on Android, but this will change in the future.

At this time, the CQ runs vr_common_unittests only on Android.  However, during development, we run the tests locally on Linux because they're much faster to compile and run (a few seconds vs. minutes per run).  To ensure that the code and tests continue to be cross-platform, and compile for developers, we should have the CQ verify the tests on Linux as well as Android.

This bug tracks determining the best way to get the tests running on Linux (FYI vs non-FYI, which Linux bot configs, etc).

Comment 1 by cjgrant@chromium.org, Jul 17 2017

Owner: bsheedy@chromium.org
Status: Assigned (was: Started)
A few extra notes from group chat:

- No need for linux 32 bit + 64 bit coverage - any Linux target should be fine.  The breaks we want to cover are mainly "non Android" issues.

- We want the CQ to catch and reject CLs that would cause the unit tests to fail on Linux.

Comment 2 by bsheedy@chromium.org, Jul 17 2017

Status: Started (was: Assigned)

Comment 3 by bsheedy@chromium.org, Jul 19 2017

Summary: Make CQ run vr_common_unittests on Windows (was: Make CQ run vr_common_unittests on Linux)
After some offline discussions, we've decided to enable the tests on Windows instead (as well as flipping enable_vr on by default for Windows).

Comment 4 by cjgrant@chromium.org, Aug 11 2017 

Hey Brian, Bill got the tests compiling on Windows right?  Is that enough to flip this on for Windows?  As he's OOO now, do you have his latest adapted code, or is it in a WIP CL somewhere?

Comment 5 by cjgrant@chromium.org, Aug 11 2017

Cc: cjgrant@chromium.org
Components: -UI>Browser>VR Internals>VR
Labels: -Proj-VR-Shell Proj-VR VR-Test

Comment 6 by bsheedy@chromium.org, Aug 18 2017

Labels: OS-Windows
Owner: billorr@chromium.org
Last I heard, Bill had gotten it to compile, but some tests were still failing. He uploaded a WIP CL a while back, but last I checked, it hadn't been updated to the point where it compiled.

Comment 7 by ddorwin@chromium.org, Sep 14 2017

Labels: -M-62 M-63
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95ae72320c9ac59929e96f4ccc586ba0183ae894

commit 95ae72320c9ac59929e96f4ccc586ba0183ae894
Author: Bill Orr <billorr@chromium.org>
Date: Thu Oct 05 21:37:38 2017

Make CQ run vr_common_unittests on Windows

There were a few clang-specific C++ extensions in use, and some warnings that hit only on MSVC.
gltf tests had to be disabled because url->path parsing is not correct on Windows.

BUG= 744675 

Change-Id: Ica976477da4b5009a68d738e71ee995af871d1f7
Reviewed-on: https://chromium-review.googlesource.com/695807
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506866}
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/animation_player.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/animation_player_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/exit_prompt_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/exit_warning_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/system_indicator_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/viewport_aware_root_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/elements/webvr_url_toast_texture.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/font_fallback.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/gltf_parser.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/gltf_parser_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/test/gl_test_environment.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/test/mock_content_input_delegate.h
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/vr_gl_util_unittest.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/chrome/browser/vr/vr_shell_renderer.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/device/vr/features/features.gni
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/device/vr/test/fake_vr_device_provider.h
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/device/vr/vr_device.cc
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/device/vr/vr_device.h
[modify] https://crrev.com/95ae72320c9ac59929e96f4ccc586ba0183ae894/testing/buildbot/chromium.win.json
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60bb2e91534fbae48807f3ad7ec7a017128db935

commit 60bb2e91534fbae48807f3ad7ec7a017128db935
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Oct 06 01:20:26 2017

Revert "Make CQ run vr_common_unittests on Windows"

This reverts commit 95ae72320c9ac59929e96f4ccc586ba0183ae894.

Reason for revert: Breaking windows compile, e.g. https://build.chromium.org/p/chromium/builders/Win/builds/59641

Original change's description:
> Make CQ run vr_common_unittests on Windows
> 
> There were a few clang-specific C++ extensions in use, and some warnings that hit only on MSVC.
> gltf tests had to be disabled because url->path parsing is not correct on Windows.
> 
> BUG= 744675 
> 
> Change-Id: Ica976477da4b5009a68d738e71ee995af871d1f7
> Reviewed-on: https://chromium-review.googlesource.com/695807
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506866}

TBR=cjgrant@chromium.org,bsheedy@chromium.org,billorr@google.com,jochen@chromium.org,billorr@chromium.org

Change-Id: I0047a3d865fc7ee4eadc9bbaf1ff5942366daa53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  744675 
Reviewed-on: https://chromium-review.googlesource.com/704056
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506937}
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/animation_player.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/animation_player_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/exit_prompt_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/exit_warning_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/system_indicator_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/viewport_aware_root_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/elements/webvr_url_toast_texture.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/font_fallback.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/gltf_parser.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/gltf_parser_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/test/gl_test_environment.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/test/mock_content_input_delegate.h
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/vr_gl_util_unittest.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/chrome/browser/vr/vr_shell_renderer.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/device/vr/features/features.gni
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/device/vr/test/fake_vr_device_provider.h
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/device/vr/vr_device.cc
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/device/vr/vr_device.h
[modify] https://crrev.com/60bb2e91534fbae48807f3ad7ec7a017128db935/testing/buildbot/chromium.win.json

Comment 10 by ddorwin@chromium.org, Oct 11 2017

Blocking: 773882
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fb10e281a87f051e7bb3d568e9a9e6220520f3

commit 05fb10e281a87f051e7bb3d568e9a9e6220520f3
Author: Bill Orr <billorr@chromium.org>
Date: Sat Oct 14 08:32:54 2017

Reland "Make CQ run vr_common_unittests on Windows"

This is a reland of 95ae72320c9ac59929e96f4ccc586ba0183ae894
Original change's description:
> Make CQ run vr_common_unittests on Windows
> 
> There were a few clang-specific C++ extensions in use, and some warnings that hit only on MSVC.
> gltf tests had to be disabled because url->path parsing is not correct on Windows.
> 
> BUG= 744675 
> 
> Change-Id: Ica976477da4b5009a68d738e71ee995af871d1f7
> Reviewed-on: https://chromium-review.googlesource.com/695807
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506866}

Bug:  744675 
Change-Id: I276c82434188787660954eea6260789099f4b4d8
Reviewed-on: https://chromium-review.googlesource.com/706544
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508934}
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/animation_player.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/animation_player_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/exit_prompt_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/exit_warning_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/system_indicator_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/viewport_aware_root_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/elements/webvr_url_toast_texture.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/font_fallback.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/gltf_parser.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/gltf_parser_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/test/gl_test_environment.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/test/mock_content_input_delegate.h
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/ui_scene_manager_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/vr_gl_util_unittest.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/chrome/browser/vr/vr_shell_renderer.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/device/vr/features/features.gni
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/device/vr/test/fake_vr_device_provider.h
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/device/vr/vr_device.cc
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/device/vr/vr_device.h
[modify] https://crrev.com/05fb10e281a87f051e7bb3d568e9a9e6220520f3/testing/buildbot/chromium.win.json

Comment 12 by ddorwin@chromium.org, Oct 20 2017

Labels: -M-63 M-64

Comment 13 by billorr@chromium.org, Nov 2 2017

Status: Fixed (was: Started)

Comment 14 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment