New issue
Advanced search Search tips

Issue 744662 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PepperTCPSocketMessageFilter should participate in NetLog

Project Member Reported by davidben@chromium.org, Jul 17 2017

Issue description

PepperTCPSocketMessageFilter sometimes creates SSL sockets, but they don't have a NetLog.  Issue #742324  is an instance of this where we have a hard time diagnosing issues because thee sockets don't have a NetLog attached.
 

Comment 1 by mmenke@chromium.org, Jul 17 2017

Components: Internals>Plugins>Pepper

Comment 2 by eroman@chromium.org, Jul 20 2017

Probably just a matter of replacing the NULL NetLog* pointer the value from IOThread::net_log() / BrowserProcessImpl::net_log().

Whenever we get things like this it makes me wonder if we shouldn't just make NetLog be a global (or at least interpret nullptr as "use the globally set default")...
Status: Fixed (was: Untriaged)
Switching to the network service should have fixed this.  Huzzah!

Sign in to add a comment