New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Record UKM for autoplay

Project Member Reported by mlamouri@chromium.org, Jul 17 2017

Issue description

The metric is going to record the following events:
* Media.Autoplay.Attempt
 - AudioTrack
 - Muted
 - Source (method vs attribute)
 - UserGestureRequirement (gives an idea whether the autoplay attempt would fail)
 - VideoTrack
* Media.Autoplay.Muted.UnmuteAction
 - Result
 - Source
 
Cc: hajimehoshi@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad90070a3f3ce95f4dd9881a5c91965828e377f9

commit ad90070a3f3ce95f4dd9881a5c91965828e377f9
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Oct 17 14:41:02 2017

Autoplay: records metrics in UKM entries.

This is using the UKM service to record the autoplay attempts and
the unmute results.

Bug:  744659 
Change-Id: Ice9a259a4006beff1044e5ed62981619841895e5
Reviewed-on: https://chromium-review.googlesource.com/525692
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509384}
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/services/metrics/public/cpp/mojo_ukm_recorder.h
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/platform/weborigin/KURL.cpp
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/third_party/WebKit/Source/platform/weborigin/KURL.h
[modify] https://crrev.com/ad90070a3f3ce95f4dd9881a5c91965828e377f9/tools/metrics/ukm/ukm.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be262f67c5f85a8336f98b064e3caf25e71f7080

commit be262f67c5f85a8336f98b064e3caf25e71f7080
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Nov 01 13:22:30 2017

UKM: fix typo in Autoplay UKM event metric.

Bug:  744659 
Change-Id: I3de1c7b784759ef930239ce40b8391409cf93143
Reviewed-on: https://chromium-review.googlesource.com/746662
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513114}
[modify] https://crrev.com/be262f67c5f85a8336f98b064e3caf25e71f7080/tools/metrics/ukm/ukm.xml

Labels: M-64
Status: Fixed (was: Started)

Sign in to add a comment