Reduce comparison tolerance for createImageBitmap resize test |
|||
Issue descriptionAs reported in bugs.chromium.org/p/skia/issues/detail?id=6775, SkImage::scalePixels() does not preserve the color values of edge pixels when upscaling the image with kHigh_SkFilterQuality. As a workaround, for now the comparison tolerance of color components in createImageBitmap with resize layout tests is set to 10 (please see third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize.js). This should be set to a lower threshold when the Skia bug is addressed.
,
Dec 5 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c244a31ad974ffd8b62ac92f78154bf3136dff commit d4c244a31ad974ffd8b62ac92f78154bf3136dff Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Dec 06 21:44:59 2017 Refactor createImageBitmap resize layout tests This change reduces createImageBitmap resize test tolerance from 10 to 0 for all image sources except for blob (which is set to 5). It also refactors the tests to include pixelated, low and medium filter qualities. Furthermore, it separates the test path for premul and unpremul image bitmap sources when the filter quality is high, to match the way this is implemented in chromium. Bug: 744647 , 792607 Change-Id: I4e0b8af71d88f5885ff56540a17ec8b716cd58d7 Reviewed-on: https://chromium-review.googlesource.com/809808 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522204} [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize.js [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-blob-resize.html [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-canvas-resize.html [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-image-resize.html [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-imageData-resize.html [modify] https://crrev.com/d4c244a31ad974ffd8b62ac92f78154bf3136dff/third_party/WebKit/LayoutTests/fast/webgl/texImage-imageBitmap-from-offscreen-canvas-resize.html
,
Dec 6 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by zakerinasab@chromium.org
, Dec 5 2017