New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744596 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Omnibox lose focus when opening a new tab from NC extension

Project Member Reported by olivierrobin@chromium.org, Jul 17 2017

Issue description

When choosing "New Search" or "Incognito Search" from NC extension, if a new tab is created, keyboard appear then disappear.

Reproduction steps:
1. visit www.google.com
2. Open NC
3. Tap "New Search"

Actual Result:
Keyboard appears then disappears.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d508a5632a384270880f5616428fc9d6a37c3d3d

commit d508a5632a384270880f5616428fc9d6a37c3d3d
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Jul 19 16:29:49 2017

Execute commands on NTP in a completion handler.

When creating a new tab from the NC extension, commands can be executed
on it (focus Omnibox, launch QR Code search, launch Voice Search).
The current process relies on async call to launch the command after the
tab is created.
For some scenarios (focus Omnibox while creating a new tab), this is not
enough, and the search is cancelled by the new tab animation.

Add a completion handler in the tab creation to execute the command
the tab is created.

Bug:  744596 
Change-Id: I3e4688ff858e4ed70e7df62ac10e541a7375cbf1
Reviewed-on: https://chromium-review.googlesource.com/574537
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487881}
[modify] https://crrev.com/d508a5632a384270880f5616428fc9d6a37c3d3d/ios/chrome/app/application_delegate/url_opener_unittest.mm
[modify] https://crrev.com/d508a5632a384270880f5616428fc9d6a37c3d3d/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/d508a5632a384270880f5616428fc9d6a37c3d3d/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/d508a5632a384270880f5616428fc9d6a37c3d3d/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Tested in 62.0.3167.0 canary, iPhone 6 plus iOS 10.3.2, iPhone 7 iOS 11, 
iPad Pro iOS 11, 

iPhone 6 plus iOS 10.3.2 Works fine
iPhone 7 iOS 11 Works fine

iPad Pro iOS 11 Keyboard does not appear first time Opening incognito from NC extension.

https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLMTBObHVIOXk1bk0/view 

On iOS11, startupParameters is not initialized. So no action is done at all
Difference is that on iOS11, applicationDidBecomeActive is called *before* openURL, and on iOS10, it was after
I will have to test to see if it is the same in iPhones.
Status: Fixed (was: Assigned)
The iOS 11 bug is reaaly different.
I am opening a new bug (749037) to track it.
Status: Assigned (was: Fixed)
This is not working in iOS 11 beta 6
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment