Omnibox lose focus when opening a new tab from NC extension |
||||||
Issue descriptionWhen choosing "New Search" or "Incognito Search" from NC extension, if a new tab is created, keyboard appear then disappear. Reproduction steps: 1. visit www.google.com 2. Open NC 3. Tap "New Search" Actual Result: Keyboard appears then disappears.
,
Jul 19 2017
,
Jul 25 2017
Tested in 62.0.3167.0 canary, iPhone 6 plus iOS 10.3.2, iPhone 7 iOS 11, iPad Pro iOS 11, iPhone 6 plus iOS 10.3.2 Works fine iPhone 7 iOS 11 Works fine iPad Pro iOS 11 Keyboard does not appear first time Opening incognito from NC extension. https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLMTBObHVIOXk1bk0/view
,
Jul 26 2017
On iOS11, startupParameters is not initialized. So no action is done at all
,
Jul 26 2017
Difference is that on iOS11, applicationDidBecomeActive is called *before* openURL, and on iOS10, it was after I will have to test to see if it is the same in iPhones.
,
Jul 26 2017
The iOS 11 bug is reaaly different. I am opening a new bug (749037) to track it.
,
Aug 18 2017
This is not working in iOS 11 beta 6
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2286b25aa902225c0d9bd2376f0b0fe002539920 commit 2286b25aa902225c0d9bd2376f0b0fe002539920 Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Aug 22 15:06:56 2017 Fix startup sequence when opening external URL on iOS11+ Opening URLs did not use the startup paramaters on iOS10- as applicationDidBecomeActive handled this case. But due to the change in API calls, it is now needed. Bug: 744596 Change-Id: I40661accc1afe853fabdb324a6ac781ea97461e9 Reviewed-on: https://chromium-review.googlesource.com/625963 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#496307} [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/app/application_delegate/mock_tab_opener.mm [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/app/application_delegate/tab_opening.h [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/app/application_delegate/url_opener.mm [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/app/application_delegate/url_opener_unittest.mm [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/app/main_controller.mm [modify] https://crrev.com/2286b25aa902225c0d9bd2376f0b0fe002539920/ios/chrome/browser/app_startup_parameters.h
,
Aug 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017