Non-Regression : Left arrow for 'Cancel selection' is seen chopped when Menu list to extreme L.H.S in FilesApp |
|||||||||
Issue descriptionChrome Version: 61.0.3158.0/9751.0.0 dev-channel Kip,Minnie and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download image (2)Now go to Files App-> select image so that 'Cancel selection','Open','Delete' options are seen (3)Now drag Menu list to extreme L.H.S -> Observe Left arrow for 'Cancel selection' is seen chopped(Please refer Video) Expected: Left arrow for 'Cancel selection' should not be chopped Actual: Instead Left arrow for 'Cancel selection' is seen chopped when Menu list to extreme L.H.S This is Non-Regression Issue seen from M-55 @fukino: Please confirm the issue Note: Long press on 'Cancel selection' and observe ripple effect
,
Jul 21 2017
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f1c74b897da09af5b64781a026b8c7ba7240112 commit 8f1c74b897da09af5b64781a026b8c7ba7240112 Author: Klemen Kozjek <klemenko@google.com> Date: Mon Jul 24 05:39:07 2017 Files app: Do not break 'Cancel selection' text and use '...' instead As a result, text in cancel selection button doesn't break and chop the arrow. When Menu list is dragged to the extreme L.H.S. text gets truncated and '...' appears. Bug: 744568 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8005882d6aa3b703a5baaf4e37a4493e42e67336 Reviewed-on: https://chromium-review.googlesource.com/580173 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Commit-Position: refs/heads/master@{#488916} [modify] https://crrev.com/8f1c74b897da09af5b64781a026b8c7ba7240112/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/8f1c74b897da09af5b64781a026b8c7ba7240112/ui/file_manager/file_manager/main.html
,
Jul 24 2017
,
Jul 28 2017
This issue is not fixed yet, M61- Chrome OS 9765.9.0, 61.0.3163.16 dev build.
,
Jul 31 2017
,
Jul 31 2017
Approving merge to M61 Chrome OS.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a45f7df9dd846b9dc909163d5ef6ccbe6e68def commit 3a45f7df9dd846b9dc909163d5ef6ccbe6e68def Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 02 00:50:49 2017 Files app: Do not break 'Cancel selection' text and use '...' instead As a result, text in cancel selection button doesn't break and chop the arrow. When Menu list is dragged to the extreme L.H.S. text gets truncated and '...' appears. TBR=klemenko@google.com (cherry picked from commit 8f1c74b897da09af5b64781a026b8c7ba7240112) Bug: 744568 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8005882d6aa3b703a5baaf4e37a4493e42e67336 Reviewed-on: https://chromium-review.googlesource.com/580173 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Original-Commit-Position: refs/heads/master@{#488916} Reviewed-on: https://chromium-review.googlesource.com/595353 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#226} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/3a45f7df9dd846b9dc909163d5ef6ccbe6e68def/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/3a45f7df9dd846b9dc909163d5ef6ccbe6e68def/ui/file_manager/file_manager/main.html
,
Aug 4 2017
,
Aug 7 2017
Verified on M62 (Chrome OS 9817.0.0, 62.0.3176.0 dev build). |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by fukino@chromium.org
, Jul 19 2017Owner: klemenko@google.com