New issue
Advanced search Search tips

Issue 744565 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 742294
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

build/android/adb_run_chrome_public fails without parameter

Project Member Reported by dullweber@chromium.org, Jul 17 2017

Issue description

When I run build/android/adb_run_chrome_public, Chrome crashes in WarmupManager.maybePreconnectUrlAndSubResources(WarmupManager.java:232). 

It seems to expect a URL. 

If I pass a URl, Chrome Custom Tabs is opened instead of Chrome.

Previously I could start Chrome with this command. I'm not sure what happened when I pass a URL but I don't think that it should open CCT by default.
(It is documented to start Chrome https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_instructions.md#Running)

Stacktrace:

07-17 14:20:27.474 20556-20556/org.chromium.chrome E/chromium: [ERROR:shell_integration_android.cc(22)] Not implemented reached in shell_integration::DefaultWebClientSetPermission shell_integration::GetDefaultWebClientSetPermission()
07-17 14:20:27.689 20556-20556/org.chromium.chrome E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: org.chromium.chrome, PID: 20556
                                                                     java.lang.NullPointerException: uriString
                                                                         at android.net.Uri$StringUri.<init>(Uri.java:475)
                                                                         at android.net.Uri$StringUri.<init>(Uri.java)
                                                                         at android.net.Uri.parse(Uri.java:437)
                                                                         at org.chromium.chrome.browser.WarmupManager.maybePreconnectUrlAndSubResources(WarmupManager.java:232)
                                                                         at org.chromium.chrome.browser.init.AsyncInitializationActivity.maybePreconnect(AsyncInitializationActivity.java:190)
                                                                         at org.chromium.chrome.browser.init.ChromeBrowserInitializer$5.initFunction(ChromeBrowserInitializer.java:300)
                                                                         at org.chromium.chrome.browser.init.ChromeBrowserInitializer$1NativeInitTask.run(ChromeBrowserInitializer.java:263)
                                                                         at android.os.Handler.handleCallback(Handler.java:751)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                         at android.os.Looper.loop(Looper.java:154)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6121)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
 
Cc: lizeb@chromium.org
https://crrev.com/2970003003 added Uri.parse to WarmupManager. The issue did't exist before it.

lizeb@ could you take a look?
Cc: -lizeb@chromium.org
Owner: lizeb@chromium.org
Status: Assigned (was: Untriaged)
tentatively assigning per #1, feel free to release back to I>C>A if necesssary.
Labels: -Pri-3 Pri-2
lizeb: did you already take a look at this? 
This problem breaks the suggested approach from our documentation on how to run Chrome on Android. 

Comment 4 by lizeb@chromium.org, Jul 19 2017

Mergedinto: 742294
Status: Duplicate (was: Assigned)
Yeah, it's a duplicate of 742294, which is fixed, and has a non-regression test in review.

Sign in to add a comment