New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744551 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Add button is seen disabled in 'Add a printer manually' screen even on entering all the details.

Project Member Reported by jbanavatu@chromium.org, Jul 17 2017

Issue description

Chrome Version:61.0.3158.0/9751.0.0 dev channel Daisy,Minnie,Kip
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign in to chrome or Browse as guest >> Navigate to chrome://settings/cupsPrinters page
(2)Click on Add Printer button >> In 'Add a printer manually' screen, enter all details and Observe Add button.

Expected:Add button should be enabled after entering all mandatory details.
Actual: Instead, Add button is seen disabled(Unable to add printer manually until unless we go to 'Add a nearby printer' screen >> click cancel and navigate back to 'Add a printer manually' screen.)

This is regression issue as add button is enabled when all mandatory details are entered in 61.0.3156.0/9744.0.0 dev channel Minnie.

Note: 
1. Add button is enabled only after clicking cancel in 'Add a nearby printer' screen and navigating back to 'Add a printer manually' screen.
2. Issue is not applicable to Linux and Windows.

Attaching screen-cast for reference.
 
Actual.webm
1.8 MB View Download
Cc: steve...@chromium.org
Owner: x...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7a974a588f24f1c5cffb39477fa65f13d154b92

commit a7a974a588f24f1c5cffb39477fa65f13d154b92
Author: xdai <xdai@chromium.org>
Date: Tue Jul 18 00:41:29 2017

[CUPS] Fix the regression that "Add" button is disabled on manual-add-printer dialog.

It's a regression caused by https://codereview.chromium.org/2979903003/.
We need to make sure newPrinter is not a null object when automatically
switch from auto-discovery dialog to manual-add-printer dialog.

Bug:  744551 
Change-Id: If535c64aa2bb716e3f8e813852b556f6f6f8f796
Reviewed-on: https://chromium-review.googlesource.com/575381
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487319}
[modify] https://crrev.com/a7a974a588f24f1c5cffb39477fa65f13d154b92/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 3 by x...@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: Verified (was: Fixed)
Verified on M61 (Chrome OS 9765.7.0, 61.0.3163.13 dev build)

Sign in to add a comment