Regression: [DevTools]Keyboard navigation issues is observed under Audits section.
Reported by
dchau...@etouch.net,
Jul 17 2017
|
|||||
Issue descriptionChrome Version: 61.0.3159.0 (Official Build) c421374e09e082113bb53970f2cf650f2130c61a-refs/heads/master@{#486995} 32/64-bit. OS: Windows (7,8,10), Mac (10.11.6, 10.12.3), Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, go to www.facebook.com open DevTools and go to 'Audits' section. 2. Run the audit by clicking on 'Perform an audit' and 'Run audit' buttons. 3. Now, Expand the m.facebook.com from left panel. 4. Press down arrow key such that focus reaches to Progressive WebApp, Performance, Accessibility and Best Practices section and observe. Actual: On pressing the down arrow key, It doesn't navigate to corresponding section when focus reaches to WebApp, Performance, Accessibility and Best Practices section. Expected: On pressing the down arrow key, It should navigate to corresponding section when focus reaches to WebApp, Performance, Accessibility and Best Practices section. This is a regression issue, broken in M-61 series, below is manual regression range. Good build: 61.0.3135.0 Bad build: 61.0.3136.0 Kindly review the attached screen-cast for reference.
,
Jul 17 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3135.0(Revision:480321). Bad build:61.0.3136.0(Revision:480665). You are probably looking for a change made after 480556 (known good), but no later than 480557 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/436ccfe33a1747eb5e4d4b9ed948d498d560bf19..0e2afe148b2aea0aaef135379d01b1df986be46c From the CL above, assigning the issue to the concern owner @sunyunjia: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2938373003 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3159.0 Adding Release Block-Stable for this issue.Please remove if not the case.
,
Jul 17 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76e234ed8928315841951a5f170232e9c959633d commit 76e234ed8928315841951a5f170232e9c959633d Author: Sandra Sun <sunyunjia@chromium.org> Date: Wed Jul 19 00:49:32 2017 Remove nextSelectedElement.reveal() in treeoutline.js In dev-tools, the lighthouse generates a report after auditing a page. The report contains several sections and should reveal both the relevant section and the item as user navigates through the items in the left navigation bar (see bug description). In the current implementation, javascript executes nextSelectedElement.reveal(), and nextSelectedElement.select(), where reveal() scrolls the item into view after select() is executed to focus on the item then scroll the section. However, the section has scroll-behavior:smooth, which would be aborted by the immediate scrollIntoView called by reveal(). In fact, in select(), we have already focused the item and have scrolled it into view, so the reveal() function call is redundant, thus we remove them in this patch to ensure the section can be scrolled into view smoothly. Bug: 744512 Change-Id: I12813467862c466fcc7ad67ab3d0fc3eed9ef93f Reviewed-on: https://chromium-review.googlesource.com/574659 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487694} [modify] https://crrev.com/76e234ed8928315841951a5f170232e9c959633d/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
,
Jul 19 2017
,
Jul 26 2017
Rechecked this issue on Windows 10, Mac 10.11.6, Ubuntu 14.04 using chrome version 61.0.3163.13 and fix is working as expected. Note: Left panel is removed from build #61.0.3163.0 Attaching screen-cast for the same. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dchau...@etouch.net
, Jul 17 20171.5 MB
1.5 MB View Download
1.5 MB
1.5 MB View Download