New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744499 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
OOO until 4th
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 333943
issue 636981



Sign in to add a comment

Consider downloading `ftp://` resources rather than rendering them.

Project Member Reported by mkwst@chromium.org, Jul 17 2017

Issue description

When even the linux kernel is migrating off FTP[1], it's really time for us to move on. :) I'd suggest that instead of rendering resources when folks navigate to `ftp://` origins, we instead download them.

That is, navigating to `ftp://labs.gwendragon.de/a.html` would download `a.html` rather than renderinf the HTML page, navigating to `ftp://labs.gwendragon.de/a.mkv` would download `a.mkv` rather than synthesizing an HTML page to play the video, and so on.

[1]: https://www.kernel.org/shutting-down-ftp-services.html
 

Comment 1 by mmenke@chromium.org, Jul 17 2017

From a practical standpoint, how would we implement this?  At the mime sniffing layer?  I don't think we can know if a path is a directory or not until around that point.

Comment 2 by mmenke@chromium.org, Aug 16 2017

Simplest way would probably be to give FTP non-directory listing responses a bogus binary/octet stream mime type at the URLRequestFTPJob layer, which would bypass mime sniffing entirely.  Anyhow, I support this change.
Related  Issue 499063 . :)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: eroman@chromium.org
Status: Available (was: Untriaged)
Hrm...I had thought we already did this.  I guess not.
Cc: emilyschechter@chromium.org
This is something I really do want to do, it's just a question of bandwidth.

PMily: Where does FTP fall on Enamel's internal list of Things to get Rid Of? This is a nice baby step in the direction of removal that I'd like us to think about in Q4 or Q1.
Blocking: 333943
Owner: mkwst@chromium.org
Status: Started (was: Available)
Blocking: 636981
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80462a167555039c1d7276694b476466fa581e45

commit 80462a167555039c1d7276694b476466fa581e45
Author: Mike West <mkwst@chromium.org>
Date: Tue Nov 27 16:05:06 2018

Download FTP resources, do not render them.

With the exception of generated directory listing pages, resources
requested via FTP will be downloaded rather than rendered.

Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eopgOoY1QLs
Spec: https://github.com/whatwg/fetch/pull/839

Bug:  744499 
Change-Id: Ic04f17986cbceb511a19d541f4dd4c67685df81a
Reviewed-on: https://chromium-review.googlesource.com/c/1337338
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611125}
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/chrome/browser/net/ftp_browsertest.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/net/base/mime_sniffer.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/net/base/mime_sniffer_unittest.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/net/url_request/url_request_ftp_job.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/80462a167555039c1d7276694b476466fa581e45/net/url_request/url_request_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment