New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 744493 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Chrome Home shows cut off image after deleting history

Project Member Reported by dullweber@chromium.org, Jul 17 2017

Issue description

I discovered another case, where the empty Chrome Home message appears cut off:

1. Open Chrome Home
2. Go to History -> Clear Browsing Data
3. Delete History
4. Go back to Home
5. Swipe away "That's all for now"
6. See cut off image 

Chrome Canary 61.0.3159
 
3710415161346866537-account_id=1.png
228 KB View Download
5369494099083547720-account_id=1.png
267 KB View Download
Cc: -mvanouwerkerk@google.com mvanouwe...@chromium.org
Labels: OS-Android
Owner: mvanouwe...@chromium.org
Status: Assigned (was: Untriaged)
Labels: zine-client

Comment 4 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged

Comment 5 by bauerb@chromium.org, Aug 10 2017

Owner: bauerb@chromium.org
Status: Started (was: Assigned)
One-line fix!!!11!
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/430662b24f90fb9eff40118633e205af8ba3ff6e

commit 430662b24f90fb9eff40118633e205af8ba3ff6e
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed Aug 16 13:39:29 2017

[Chrome Home] Size suggestions RecyclerView to match parent.

Bug:  744493 
Change-Id: I7fad6c543701ac2991686dc2c554b7e7979b6e64
Reviewed-on: https://chromium-review.googlesource.com/610082
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494760}
[modify] https://crrev.com/430662b24f90fb9eff40118633e205af8ba3ff6e/chrome/android/java/res/layout/suggestions_bottom_sheet_content.xml

Comment 7 by bauerb@chromium.org, Sep 22 2017

Status: Fixed (was: Started)

Sign in to add a comment