New issue
Advanced search Search tips

Issue 744405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Support replacement as label for the replacement encoding

Project Member Reported by annevank...@gmail.com, Jul 17 2017

Issue description

Comment 1 by jsb...@chromium.org, Jul 17 2017

Cc: js...@chromium.org
Owner: jsb...@chromium.org
Status: Started (was: Unconfirmed)
CL: https://chromium-review.googlesource.com/c/559973/

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28c894b69c664e7ba4a7b53961fb57a023a42669

commit 28c894b69c664e7ba4a7b53961fb57a023a42669
Author: Joshua Bell <jsbell@chromium.org>
Date: Mon Jul 17 23:52:50 2017

Text Encoding: Add 'replacement' as label for replacement encoding

The 'replacement' encoding originated as a spec concept to prevent
security attacks via problematic encodings by recognizing the
label but not decoding the stream.

It was initially specified as the only encoding where the name
wasn't one of the labels, requiring special cases in all implementations.
Based on more implementer feedback we'd like to remove the special
case. Delete the special case code in Blink too.

See also: https://github.com/whatwg/encoding/issues/70

Bug:  744405 

Change-Id: Ia15ccef1a9d7f35c23af4509a5a9758cbefc2087
Reviewed-on: https://chromium-review.googlesource.com/559973
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487288}
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/LayoutTests/fast/encoding/char-decoding.html
[delete] https://crrev.com/19d792a377d6854e46acb0fd786b48f0690ad9d1/third_party/WebKit/LayoutTests/fast/encoding/charset-replacement-expected.txt
[delete] https://crrev.com/19d792a377d6854e46acb0fd786b48f0690ad9d1/third_party/WebKit/LayoutTests/fast/encoding/charset-replacement.html
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.cpp
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.h
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextCodecReplacementTest.cpp
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextEncoding.cpp
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextEncodingRegistry.cpp
[modify] https://crrev.com/28c894b69c664e7ba4a7b53961fb57a023a42669/third_party/WebKit/Source/platform/wtf/text/TextEncodingRegistry.h

Comment 3 by jsb...@chromium.org, Jul 17 2017

Status: Fixed (was: Started)

Sign in to add a comment