New issue
Advanced search Search tips

Issue 744354 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-36.9% regression in system_health.memory_desktop at 486094:486358

Project Member Reported by mlippautz@google.com, Jul 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=744354

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f92f278965c260c957a5c619c176cc8e2083aacda05661acc9064ed738a5d77e


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jul 17 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_news/load_news_hackernews

Revision             Result              N
chromium@486232      4386816 +- 0.0      21      good
chromium@486351      4386816 +- 0.0      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.hackernews system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973837170002531440


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jul 17 2017

Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : aa69a48f78a3fd0fdc90ddb16108fd149a30d5f8
  Date   : Wed Jul 12 21:51:20 2017
  Subject: Disable StringConcat bytecode.

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_games/load_games_bubbles
  Change       : 10.43% | 8719786.66667 -> 9629310.66667

Revision                           Result                  N
chromium@486230                    8719787 +- 70079.4      6      good
chromium@486241                    8733887 +- 136258       6      good
chromium@486247                    8817122 +- 875843       9      good
chromium@486248                    8701436 +- 66454.2      6      good
chromium@486248,v8@fa4ec9fdbe      8774370 +- 152606       9      good
chromium@486248,v8@53fa87354e      8803372 +- 228360       9      good
chromium@486248,v8@b56c0f7a7e      8746765 +- 105246       9      good
chromium@486248,v8@aa69a48f78      9533652 +- 889196       9      bad       <--
chromium@486249                    9425657 +- 1049483      9      bad
chromium@486250                    9619972 +- 102487       9      bad
chromium@486252                    9484021 +- 756462       6      bad
chromium@486273                    9649171 +- 97243.0      6      bad
chromium@486316                    9629311 +- 54235.3      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.bubbles system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973837163867212640


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jul 17 2017

Cc: cbruni@chromium.org
Owner: cbruni@chromium.org

=== Auto-CCing suspected CL author cbruni@chromium.org ===

Hi cbruni@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Camillo Bruni
  Commit : 36421dc467bffcdcb71967ed39dddca1e33d48c6
  Date   : Wed Jul 12 19:11:04 2017
  Subject: [literals] Disable double lazy boilerplate for literals containing Arrays

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_search/load_search_google
  Change       : 5.97% | 10456802.6667 -> 11081074.6667

Revision                           Result                   N
chromium@486230                    10456803 +- 2282.67      6      good
chromium@486241                    10457789 +- 1690.17      6      good
chromium@486247                    10457248 +- 1920.3       6      good
chromium@486248                    10457027 +- 1967.76      6      good
chromium@486248,v8@42c8df3f46      10456836 +- 2286.23      6      good
chromium@486248,v8@34874b3b19      10457917 +- 1219.87      6      good
chromium@486248,v8@36421dc467      11081244 +- 1546.95      6      bad       <--
chromium@486248,v8@fa4ec9fdbe      11081305 +- 1537.35      6      bad
chromium@486249                    11081645 +- 1429.05      6      bad
chromium@486250                    11081645 +- 1429.05      6      bad
chromium@486252                    11080959 +- 1931.65      6      bad
chromium@486273                    11081061 +- 2080.08      6      bad
chromium@486316                    11081075 +- 2093.73      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.google system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973837188260002368


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Google
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jul 17 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : v8-gc-incremental-step_sum/browse_media/browse_media_flickr_infinite_scroll
  Change       : 25.13% | 203.375642857 -> 264.369666667

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/0e84cea67c8d24ab6a8d7cb1efdf5ec467c6dc38..6d016c9355721f174c345002f89cb9f750655f6a


Revision             Result                  N
chromium@486218      203.376 +- 122.627      14       good
chromium@486240      205.761 +- 149.381      14       good
chromium@486245      212.952 +- 168.579      21       good
chromium@486247      198.209 +- 131.305      14       good
chromium@486248      192.823 +- 160.916      14       good
chromium@486249      ---                     ---      build failure
chromium@486250      248.126 +- 83.1506      14       bad
chromium@486258      242.794 +- 57.7936      14       bad
chromium@486298      264.37 +- 37.6151       6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.flickr.infinite.scroll v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973837234672041344


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Untriaged)
This is somewhat expected as I had to revert a previously too aggressive optimization.
Hence we jumped back to previous values for array literals.

I will try to limit the impact of this CL by lazily creating the allocation sites for array literals but still immediately start tracking the elements kind transitions.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jul 21 2017

 Issue 747239  has been merged into this issue.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Jul 25 2017

 Issue 745371  has been merged into this issue.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jul 25 2017

 Issue 745371  has been merged into this issue.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Jul 25 2017

 Issue 745371  has been merged into this issue.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Jul 27 2017

Cc: nzolghadr@chromium.org
 Issue 744689  has been merged into this issue.
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Jul 28 2017

Cc: reed@google.com mtklein@chromium.org benhenry@google.com fmalita@chromium.org
 Issue 747027  has been merged into this issue.

Sign in to add a comment