Regression: Text Continuation is not proper in thumbnails of NTP |
||||||
Issue descriptionChrome Version:61.0.3159.0 OS:Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Launch chrome and open NTP (2)Observe the Text continuation for long names on the thumbnails Expected:Text continuation should not be seen.. If its intended it should be seen beside the name. Actual:Instead, Unwanted text continuation is seen in thumbnails This is a Regression issue broken in M-61 will update other info soon..
,
Jul 17 2017
Able to reproduce this issue on Mac OS 10.12.5 using chrome latest Dev #61.0.3159.0.
,
Jul 17 2017
Providing per-revision bisect information below Bisect Information: --------------------- You are probably looking for a change made after 486503 (known good), but no later than 486504 (first known bad). Change Log URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/b694253de687440c5e180ffef488f5e1b6a6eee3..74bd1c084916b057eb7936bf9871721eb0e61fa3 robhogan@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Since this is a latest regression seen on chrome latest M61 adding RB-Stable, please feel free to edit if this is not the case. Thanks!
,
Jul 17 2017
,
Jul 17 2017
I've verified that reverting 74bd1c084916b057eb7936bf9871721eb0e61fa3 (i.e. above CL) fixes the problem. It's conceivable that the new ellipsis behavior is actually correct, and the NTP is doing something wrong which just happened to work with the old behavior, but that seems unlikely.
,
Jul 18 2017
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00d5a66a3be6746400f1f65b7e1a3cd97e950f36 commit 00d5a66a3be6746400f1f65b7e1a3cd97e950f36 Author: Robert Hogan <robhogan@gmail.com> Date: Tue Jul 18 23:38:04 2017 Only apply offset to ellipsis from relative inlines A follow-up to https://chromium-review.googlesource.com/c/563625/ Bug: 744265 Change-Id: I8cac8b1f421d8a2078a002b07f965e2ab5b0837b Reviewed-on: https://chromium-review.googlesource.com/574853 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487669} [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-absolute-block-expected.txt [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-absolute-block.html [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-in-absolute-block-expected.png [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-in-absolute-block-expected.png [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-in-absolute-block-expected.png [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-in-absolute-block-expected.png [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-in-absolute-block-expected.png [add] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/LayoutTests/platform/win7/fast/text/ellipsis-in-absolute-block-expected.png [modify] https://crrev.com/00d5a66a3be6746400f1f65b7e1a3cd97e950f36/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
,
Jul 19 2017
Above CL fixes the issue. Thanks for the quick turnaround! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by keerthan...@techmahindra.com
, Jul 17 2017134 KB
134 KB View Download