New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 744229 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Feb 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Added bookmark gets deleted after clicking on toast 'Undo' button of 'Folder sorted'

Reported by sans...@etouch.net, Jul 17 2017 
Chrome Version: 61.0.3159.0 (Official Build)c421374e09e082113bb53970f2cf650f2130c61a-refs/heads/master@{#486995}-32/64 bit
OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

1. Launch Chrome, open NTP and bookmark it.
2. Navigate to chrome://bookmarks and select 'Sort by title' option from Organize menu
3. Click on 'Undo' option and observe

Actual: Added bookmark gets deleted after clicking on toast 'Undo' button of 'Folder sorted'

Expected: Added bookmark should not get deleted after clicking on toast 'Undo' button of 'Folder sorted'

This is regression issue, broken in ‘M 61’ and will soon update other info :

Good build:61.0.3123.0
Bad build: 61.0.3124.0
Actual_video.mp4
426 KB View Download

Comment 1 by msrchandra@chromium.org, Jul 17 2017

Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 61.0.3123.0 (Revision: 477506).
Bad build : 61.0.3124.0 (Revision: 477839).

You are probably looking for a change made after 477563 (known good), but no later than 477564 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/121fec7bb384638df1cc3e26fda0bed886970a38..efe47735cb33458311b6d71a3ff47ff65f4200e8

@calamity: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4e114fba946a65d7feed134172db53210757a9b

commit b4e114fba946a65d7feed134172db53210757a9b
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Aug 29 03:19:13 2017

[MD Bookmarks] Make folder sorting only avaiable for >1 bookmarks.

This CL fixes an issue where a single item sort is a no-op and messes up
the undo stack.

Bug:  744229 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f5f4123e57451bd730bcef77fa3ace7fff19601
Reviewed-on: https://chromium-review.googlesource.com/634844
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498007}
[modify] https://crrev.com/b4e114fba946a65d7feed134172db53210757a9b/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/b4e114fba946a65d7feed134172db53210757a9b/chrome/test/data/webui/md_bookmarks/toolbar_test.js

Comment 3 by calamity@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment